AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[fuchsia] Use SDK provided gn templates for d8"

Browse Source 
This reverts commit 3111db91f8.

Reason for revert: This has runtime failures because including
cmx fragments isn't working ocrrectly. Still investigating why
this wasn't discovered by CQ.

Original change's description:
> [fuchsia] Use SDK provided gn templates for d8
>
> cr_fuchsia_package is deprecated in favor of using the Fuchsia
> SDK provided rules directly.
>
> This CL adds a cmx file specifically for v8_unittests. CMX
> files define fuchsia components, see
> https://chromium-review.googlesource.com/c/chromium/src/+/3529652
> for more info.
>
> Bug: chromium:1092804
> Change-Id: Ibf1d866ec6b94a0e1a7a7c7c443a6ee80e3b1042
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3537885
> Reviewed-by: Victor Gomes <victorgomes@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Camillo Bruni <cbruni@chromium.org>
> Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#79760}

Bug: chromium:1092804
Change-Id: Ib9a4d4f8e04c6cd7f3bd289e7c956b6115a77a25
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572004
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Bryant Chandler <bryantchandler@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79860}
This commit is contained in:
Bryant Chandler 2022-04-05 16:49:04 +00:00 committed by V8 LUCI CQ
parent 16e464fb21
commit e6e4da2ff3
2 changed files with 5 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
BUILD.gn
View File

@ -6055,23 +6055,17 @@ group("v8_archive") {
if (is_fuchsia && !build_with_chromium) {
import("//build/config/fuchsia/rules.gni")
fuchsia_component("d8_fuchsia_component") {
cr_fuchsia_package("d8_fuchsia_pkg") {
testonly = true
manifest = "src/d8/d8.cmx"
data_deps = [ ":d8" ]
visibility = [ ":*" ]
}
fuchsia_package("d8_fuchsia_pkg") {
testonly = true
package_name = "d8"
deps = [ ":d8_fuchsia_component" ]
binary = ":d8"
manifest = "gni/v8.cmx"
package_name_override = "d8"
}
fuchsia_package_runner("d8_fuchsia") {
testonly = true
package = ":d8_fuchsia_pkg"
package_name = "d8"
package_name_override = "d8"
}
}

9
src/d8/d8.cmx
View File

@ -1,9 +0,0 @@
{
"include": [
"build/config/fuchsia/test/minimum_capabilities.test-cmx",
"gni/v8.cmx"
],
"program": {
"binary": "d8"
}
}