AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Fixup wrong code comments.

Browse Source 
Missed the feedback in https://chromium-review.googlesource.com/1611803
to address the code comments.

Tbr: neis@chromium.org
Bug: chromium:961199, v8:8820
Change-Id: I1ff85c0a7554099b72461eb91de9ea4bb2a5bded
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1617242
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61597}
This commit is contained in:
Benedikt Meurer 2019-05-17 08:37:07 +02:00 committed by Commit Bot
parent 3000b890f9
commit e73776cfe3
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/builtins/builtins-call-gen.cc
View File

@ -500,7 +500,7 @@ void CallOrConstructBuiltinsAssembler::CallFunctionTemplate(
// For API callbacks the receiver is always a JSReceiver (since
// they are treated like sloppy mode functions). We might need
// to perform access checks int the current {context}, depending
// to perform access checks in the current {context}, depending
// on whether the "needs access check" bit is set on the receiver
// _and_ the {function_template_info} doesn't have the "accepts
// any receiver" bit set.

15
src/compiler/js-call-reducer.cc
View File

@ -2834,13 +2834,6 @@ Reduction JSCallReducer::ReduceCallApiFunction(
graph()->NewNode(simplified()->ConvertReceiver(p.convert_mode()),
receiver, global_proxy, effect, control);
} else {
// The CallFunctionTemplate builtin requires the {receiver} to be
// an actual JSReceiver, so make sure we do the proper conversion
// first if necessary.
receiver = holder = effect =
graph()->NewNode(simplified()->ConvertReceiver(p.convert_mode()),
receiver, global_proxy, effect, control);
// We don't have enough information to eliminate the access check
// and/or the compatible receiver check, so use the generic builtin
// that does those checks dynamically. This is still significantly
@ -2852,6 +2845,14 @@ Reduction JSCallReducer::ReduceCallApiFunction(
: Builtins::
kCallFunctionTemplate_CheckAccessAndCompatibleReceiver)
: Builtins::kCallFunctionTemplate_CheckCompatibleReceiver;
// The CallFunctionTemplate builtin requires the {receiver} to be
// an actual JSReceiver, so make sure we do the proper conversion
// first if necessary.
receiver = holder = effect =
graph()->NewNode(simplified()->ConvertReceiver(p.convert_mode()),
receiver, global_proxy, effect, control);
Callable callable = Builtins::CallableFor(isolate(), builtin_name);
auto call_descriptor = Linkage::GetStubCallDescriptor(
graph()->zone(), callable.descriptor(),