AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix some valgrind errors in d8 shell.

Browse Source 
This fixes 3 possibly lost warnings occurring when running unit tests under d8:

 28 bytes in 1 blocks are possibly lost in loss record 40 of 68
  at 0x67FB8DB: operator new[](unsigned int)
  by 0x83865CC: v8::Shell::SetOptions(int, char**) (d8.cc:1200)
  by 0x83869A5: v8::Shell::Main(int, char**) (d8.cc:1276)
  by 0x8386B31: main (d8.cc:1333)
Review URL: http://codereview.chromium.org/7780032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
fschneider@chromium.org 2011-09-13 09:31:41 +00:00
parent 81df4a42e4
commit e74033d9cc
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/d8.cc
View File

@ -1090,6 +1090,16 @@ void SourceGroup::WaitForThread() {
#endif // V8_SHARED
ShellOptions::~ShellOptions() {
delete[] isolate_sources;
isolate_sources = NULL;
#ifndef V8_SHARED
delete parallel_files;
parallel_files = NULL;
#endif // V8_SHARED
}
bool Shell::SetOptions(int argc, char* argv[]) {
for (int i = 0; i < argc; i++) {
if (strcmp(argv[i], "--stress-opt") == 0) {
@ -1198,7 +1208,7 @@ bool Shell::SetOptions(int argc, char* argv[]) {
v8::V8::SetFlagsFromCommandLine(&argc, argv, true);
// set up isolated source groups
// Set up isolated source groups.
options.isolate_sources = new SourceGroup[options.num_isolates];
SourceGroup* current = options.isolate_sources;
current->Begin(argv, 1);

2
src/d8.h
View File

@ -191,6 +191,8 @@ class ShellOptions {
num_isolates(1),
isolate_sources(NULL) { }
~ShellOptions();
#ifndef V8_SHARED
bool use_preemption;
int preemption_interval;