AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Do not recompile existing functions when enabling allocation tracking

Browse Source 
Now that we don't have special hooks for the allocations in the generated code there is no need to recompile existing functions when enabling allocation tracking.

BUG=chromium:27798
LOG=N
R=loislo@chromium.org, mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/67743006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17932 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yurys@chromium.org 2013-11-20 14:57:39 +00:00
parent 1e8c7c56d2
commit e7511b6234
2 changed files with 0 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/heap-profiler.cc
View File

@ -27,7 +27,6 @@
#include "v8.h"
#include "deoptimizer.h"
#include "heap-profiler.h"
#include "heap-snapshot-generator-inl.h"
@ -160,7 +159,6 @@ void HeapProfiler::StartHeapAllocationsRecording() {
StartHeapObjectsTracking();
heap()->DisableInlineAllocation();
is_tracking_allocations_ = true;
DropCompiledCode();
snapshots_->UpdateHeapObjectsMap();
}
@ -169,45 +167,6 @@ void HeapProfiler::StopHeapAllocationsRecording() {
StopHeapObjectsTracking();
heap()->EnableInlineAllocation();
is_tracking_allocations_ = false;
DropCompiledCode();
}
void HeapProfiler::DropCompiledCode() {
Isolate* isolate = heap()->isolate();
HandleScope scope(isolate);
if (isolate->concurrent_recompilation_enabled()) {
isolate->optimizing_compiler_thread()->Flush();
}
Deoptimizer::DeoptimizeAll(isolate);
Handle<Code> lazy_compile =
Handle<Code>(isolate->builtins()->builtin(Builtins::kLazyCompile));
heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,
"switch allocations tracking");
DisallowHeapAllocation no_allocation;
HeapIterator iterator(heap());
HeapObject* obj = NULL;
while (((obj = iterator.next()) != NULL)) {
if (obj->IsJSFunction()) {
JSFunction* function = JSFunction::cast(obj);
SharedFunctionInfo* shared = function->shared();
if (!shared->allows_lazy_compilation()) continue;
if (!shared->script()->IsScript()) continue;
Code::Kind kind = function->code()->kind();
if (kind == Code::FUNCTION || kind == Code::BUILTIN) {
function->set_code(*lazy_compile);
shared->set_code(*lazy_compile);
}
}
}
}

2
src/heap-profiler.h
View File

@ -90,8 +90,6 @@ class HeapProfiler {
return snapshots_->FindUntrackedObjects();
}
void DropCompiledCode();
private:
Heap* heap() const { return snapshots_->heap(); }