From e78ebe447b150794febd3989c20ae31a34774288 Mon Sep 17 00:00:00 2001 From: Mike Stanton Date: Tue, 31 Dec 2019 14:57:05 +0100 Subject: [PATCH] [TurboFan] Remove serialized function limit This limit hangs TypeScript and needs further investigation. Bug: chromium:1038292 Change-Id: I5270052cb2b357f9f872d6de42a8122cee81b13e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981499 Reviewed-by: Jakob Gruber Commit-Queue: Michael Stanton Cr-Commit-Position: refs/heads/master@{#65568} --- src/compiler/js-heap-broker.cc | 5 ----- src/compiler/js-heap-broker.h | 1 - 2 files changed, 6 deletions(-) diff --git a/src/compiler/js-heap-broker.cc b/src/compiler/js-heap-broker.cc index a1b777d57a..75fd444647 100644 --- a/src/compiler/js-heap-broker.cc +++ b/src/compiler/js-heap-broker.cc @@ -2525,11 +2525,6 @@ bool JSHeapBroker::ShouldBeSerializedForCompilation( void JSHeapBroker::SetSerializedForCompilation( const SharedFunctionInfoRef& shared, const FeedbackVectorRef& feedback, const HintsVector& arguments) { - if (serialized_functions_.size() >= kMaxSerializedFunctionsCacheSize) { - TRACE_BROKER_MISSING(this, - "opportunity - serialized functions cache is full."); - return; - } SerializedFunction function{shared, feedback}; serialized_functions_.insert({function, arguments}); TRACE(this, "Set function " << shared << " with " << feedback diff --git a/src/compiler/js-heap-broker.h b/src/compiler/js-heap-broker.h index 80afb3f4ab..28dabb1c4a 100644 --- a/src/compiler/js-heap-broker.h +++ b/src/compiler/js-heap-broker.h @@ -265,7 +265,6 @@ class V8_EXPORT_PRIVATE JSHeapBroker { } }; ZoneMultimap serialized_functions_; - static const size_t kMaxSerializedFunctionsCacheSize = 200; static const size_t kMinimalRefsBucketCount = 8; // must be power of 2 static const size_t kInitialRefsBucketCount = 1024; // must be power of 2