AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[crankshaft] Write fillers for folded old space allocations during verify-heap

Browse Source 
If we don't write fillers, we crash during PagedSpace verification when we try
to iterate over dead memory (unused folded allocation slots).

BUG=v8:4871,chromium:580959
LOG=N

Review URL: https://codereview.chromium.org/1837163002

Cr-Commit-Position: refs/heads/master@{#35097}
This commit is contained in:
mlippautz 2016-03-29 04:42:36 -07:00 committed by Commit bot
parent c9f59780f7
commit e7cc6091f5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/crankshaft/hydrogen-instructions.cc
View File

@ -3254,12 +3254,12 @@ bool HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
} }
} }
bool keep_new_space_iterable = FLAG_log_gc || FLAG_heap_stats; bool keep_heap_iterable = FLAG_log_gc || FLAG_heap_stats;
#ifdef VERIFY_HEAP #ifdef VERIFY_HEAP
keep_new_space_iterable = keep_new_space_iterable || FLAG_verify_heap; keep_heap_iterable = keep_heap_iterable || FLAG_verify_heap;
#endif #endif
if (keep_new_space_iterable && dominator_allocate->IsNewSpaceAllocation()) { if (keep_heap_iterable) {
dominator_allocate->MakePrefillWithFiller(); dominator_allocate->MakePrefillWithFiller();
} else { } else {
// TODO(hpayer): This is a short-term hack to make allocation mementos // TODO(hpayer): This is a short-term hack to make allocation mementos