AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[gcc] Fix some more gcc-only warnings

Browse Source 
Bug: chromium:1307180
Change-Id: Ia279086ec3df9d64bd6a0255ebe27d9e583014c7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732937
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#81433}
This commit is contained in:
Leszek Swirski 2022-06-29 11:17:16 +02:00 committed by V8 LUCI CQ
parent 50d2276347
commit e819e24123
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/diagnostics/ia32/disasm-ia32.cc
View File

@ -545,7 +545,7 @@ int DisassemblerIA32::F7Instruction(byte* data) {
byte modrm = *++data;
int mod, regop, rm;
get_modrm(modrm, &mod, &regop, &rm);
const char* mnem = nullptr;
const char* mnem = "";
switch (regop) {
case 0:
mnem = "test";
@ -587,7 +587,7 @@ int DisassemblerIA32::D1D3C1Instruction(byte* data) {
int mod, regop, rm;
get_modrm(modrm, &mod, &regop, &rm);
int imm8 = -1;
const char* mnem = nullptr;
const char* mnem = "";
switch (regop) {
case kROL:
mnem = "rol";
@ -2075,7 +2075,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer,
data++;
int mod, regop, rm;
get_modrm(*data, &mod, &regop, &rm);
const char* mnem = nullptr;
const char* mnem = "";
switch (regop) {
case esi:
mnem = "push";
@ -2122,7 +2122,7 @@ int DisassemblerIA32::InstructionDecode(v8::base::Vector<char> out_buffer,
data++;
int mod, regop, rm;
get_modrm(*data, &mod, &regop, &rm);
const char* mnem = nullptr;
const char* mnem = "";
switch (regop) {
case 5:
mnem = "subb";

2
src/objects/js-temporal-objects.cc
View File

@ -11561,7 +11561,7 @@ Handle<BigInt> RoundNumberToIncrement(Isolate* isolate, Handle<BigInt> x,
// 1. Let quotient be x / increment.
bool is_negative;
// 2. If quotient < 0, then
if (x->IsNegative() != increment < 0) {
if (x->IsNegative() != (increment < 0)) {
// a. Let isNegative be true.
is_negative = true;
// b. Set quotient to -quotient.