AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Do not inline WorkStealingBag ops that involve vectors

Browse Source 
Reduces binary size, see bug.

Bug: chromium:736097
Change-Id: I89b4b873accf2de85d5913a30fac53972d98e78d
Reviewed-on: https://chromium-review.googlesource.com/544984
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46160}
This commit is contained in:
Michael Lippautz 2017-06-23 10:33:22 +02:00 committed by Commit Bot
parent 14d85ce89c
commit e9e2e13328
1 changed files with 22 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/heap/workstealing-bag.h
View File

@ -51,9 +51,7 @@ class WorkStealingBag {
DCHECK_LT(task_id, kMaxNumTasks);
DCHECK_NOT_NULL(private_push_segment_[task_id]);
if (!private_push_segment_[task_id]->Push(object)) {
base::LockGuard<base::Mutex> guard(&lock_);
global_pool_.push_back(private_push_segment_[task_id]);
private_push_segment_[task_id] = new Segment();
PublishPushSegmentToGlobal(task_id);
bool success = private_push_segment_[task_id]->Push(object);
USE(success);
DCHECK(success);
@ -69,12 +67,8 @@ class WorkStealingBag {
Segment* tmp = private_pop_segment_[task_id];
private_pop_segment_[task_id] = private_push_segment_[task_id];
private_push_segment_[task_id] = tmp;
} else {
base::LockGuard<base::Mutex> guard(&lock_);
if (global_pool_.empty()) return false;
delete private_pop_segment_[task_id];
private_pop_segment_[task_id] = global_pool_.back();
global_pool_.pop_back();
} else if (!StealPopSegmentFromGlobal(task_id)) {
return false;
}
bool success = private_pop_segment_[task_id]->Pop(object);
USE(success);
@ -135,6 +129,25 @@ class WorkStealingBag {
HeapObject* objects_[kCapacity];
};
// Do not inline the following functions as this would mean that vector fast
// paths are inlined into all callers. This is mainly an issue when used
// within visitors that have lots of dispatches.
V8_NOINLINE void PublishPushSegmentToGlobal(int task_id) {
base::LockGuard<base::Mutex> guard(&lock_);
global_pool_.push_back(private_push_segment_[task_id]);
private_push_segment_[task_id] = new Segment();
}
V8_NOINLINE bool StealPopSegmentFromGlobal(int task_id) {
base::LockGuard<base::Mutex> guard(&lock_);
if (global_pool_.empty()) return false;
delete private_pop_segment_[task_id];
private_pop_segment_[task_id] = global_pool_.back();
global_pool_.pop_back();
return true;
}
base::Mutex lock_;
Segment* private_pop_segment_[kMaxNumTasks];
Segment* private_push_segment_[kMaxNumTasks];