AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix register allocation in tail-call to TFJ builtin.

Browse Source 
R=jgruber@chromium.org

Bug: v8:178
Change-Id: Id00ae14cb5a50e560f93249eed4e4b20aa0a6ce7
Reviewed-on: https://chromium-review.googlesource.com/970467
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52058}
This commit is contained in:
Yang Guo 2018-03-20 12:34:40 +01:00 committed by Commit Bot
parent 78f88ef013
commit ea2007d870
3 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/builtins/builtins-internal-gen.cc
View File

@ -207,6 +207,7 @@ TF_BUILTIN(DebugBreakTrampoline, CodeStubAssembler) {
CAST(LoadObjectField(shared, SharedFunctionInfo::kCodeOffset));
// Use the ConstructTrampolineDescriptor because it passes new.target too in
// case this is called during construct.
CSA_ASSERT(this, IsCode(code));
ConstructTrampolineDescriptor descriptor(isolate());
TailCallStub(descriptor, code, context, function, new_target, arg_count);
}

4
src/compiler/instruction-selector.cc
View File

@ -891,12 +891,8 @@ void InstructionSelector::InitializeCallBuffer(Node* call, CallBuffer* buffer,
? g.UseImmediate(callee)
: call_use_fixed_target_reg
? g.UseFixed(callee, kJavaScriptCallCodeStartRegister)
#ifdef V8_EMBEDDED_BUILTINS
: is_tail_call ? g.UseUniqueRegister(callee)
: g.UseRegister(callee));
#else
: g.UseRegister(callee));
#endif
break;
case CallDescriptor::kCallAddress:
buffer->instruction_args.push_back(

3
test/cctest/cctest.status
View File

@ -133,9 +133,6 @@
'test-serialize/StartupSerializerTwice': [SKIP],
'test-serialize/StartupSerializerOnceRunScript': [SKIP],
'test-serialize/StartupSerializerTwiceRunScript': [SKIP],
# https://crbug.com/v8/7543
'test-debug/BreakPointJSBuiltin': [SKIP],
}], # ALWAYS
##############################################################################