AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] Remove unused --ignition-eager flag.

Browse Source 
BUG=v8:4280

Review-Url: https://codereview.chromium.org/2463353002
Cr-Commit-Position: refs/heads/master@{#40697}
This commit is contained in:
rmcilroy 2016-11-02 04:17:01 -07:00 committed by Commit bot
parent d2c3ae774d
commit ea5d4c1525
7 changed files with 11 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/flag-definitions.h
View File

@ -291,7 +291,6 @@ DEFINE_BOOL(ignition, false, "use ignition interpreter")
DEFINE_BOOL(ignition_staging, false, "use ignition with all staged features")
DEFINE_IMPLICATION(ignition_staging, ignition)
DEFINE_IMPLICATION(ignition_staging, ignition_osr)
DEFINE_BOOL(ignition_eager, false, "eagerly compile and parse with ignition")
DEFINE_STRING(ignition_filter, "*", "filter for ignition interpreter")
DEFINE_BOOL(ignition_deadcode, true,
"use ignition dead code elimination optimizer")

4
src/parsing/parser.cc
View File

@ -614,10 +614,6 @@ Parser::Parser(ParseInfo* info)
// Consider compiling eagerly when targeting the code cache.
can_compile_lazily &= !(FLAG_serialize_eager && info->will_serialize());
// Consider compiling eagerly when compiling bytecode for Ignition.
can_compile_lazily &= !(FLAG_ignition && FLAG_ignition_eager &&
info->isolate()->serializer_enabled());
set_default_eager_compile_hint(can_compile_lazily
? FunctionLiteral::kShouldLazyCompile
: FunctionLiteral::kShouldEagerCompile);

8
test/cctest/test-api.cc
View File

@ -14637,7 +14637,7 @@ static bool FunctionNameIs(const char* expected,
// "LazyCompile:<type><function_name>" or Function:<type><function_name>,
// where the type is one of "*", "~" or "".
static const char* kPreamble;
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) {
if (!i::FLAG_lazy) {
kPreamble = "Function:";
} else {
kPreamble = "LazyCompile:";
@ -15368,7 +15368,7 @@ THREADED_TEST(AccessChecksReenabledCorrectly) {
// Tests that ScriptData can be serialized and deserialized.
TEST(PreCompileSerialization) {
// Producing cached parser data while parsing eagerly is not supported.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
v8::V8::Initialize();
LocalContext env;
@ -24833,7 +24833,7 @@ TEST(InvalidParserCacheData) {
v8::V8::Initialize();
v8::HandleScope scope(CcTest::isolate());
LocalContext context;
if (i::FLAG_lazy && !(i::FLAG_ignition && i::FLAG_ignition_eager)) {
if (i::FLAG_lazy) {
// Cached parser data is not consumed while parsing eagerly.
TestInvalidCacheData(v8::ScriptCompiler::kConsumeParserCache);
}
@ -24849,7 +24849,7 @@ TEST(InvalidCodeCacheData) {
TEST(ParserCacheRejectedGracefully) {
// Producing cached parser data while parsing eagerly is not supported.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
i::FLAG_min_preparse_length = 0;
v8::V8::Initialize();

3
test/cctest/test-compiler.cc
View File

@ -333,8 +333,7 @@ TEST(FeedbackVectorPreservedAcrossRecompiles) {
TEST(FeedbackVectorUnaffectedByScopeChanges) {
if (i::FLAG_always_opt || !i::FLAG_lazy ||
(FLAG_ignition && FLAG_ignition_eager)) {
if (i::FLAG_always_opt || !i::FLAG_lazy) {
return;
}
CcTest::InitializeVM();

2
test/cctest/test-heap-profiler.cc
View File

@ -360,7 +360,7 @@ TEST(HeapSnapshotCodeObjects) {
}
}
CHECK(compiled_references_x);
if (i::FLAG_lazy && !(i::FLAG_ignition && i::FLAG_ignition_eager)) {
if (i::FLAG_lazy) {
CHECK(!lazy_references_x);
}
}

8
test/cctest/test-parsing.cc
View File

@ -218,7 +218,7 @@ class ScriptResource : public v8::String::ExternalOneByteStringResource {
TEST(UsingCachedData) {
// Producing cached parser data while parsing eagerly is not supported.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope handles(isolate);
@ -271,7 +271,7 @@ TEST(UsingCachedData) {
TEST(PreparseFunctionDataIsUsed) {
// Producing cached parser data while parsing eagerly is not supported.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
// This tests that we actually do use the function data generated by the
// preparser.
@ -462,7 +462,7 @@ TEST(RegressChromium62639) {
TEST(Regress928) {
// Test only applies when lazy parsing.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
i::FLAG_min_preparse_length = 0;
// Tests that the first non-toplevel function is not included in the preparse
@ -3147,7 +3147,7 @@ TEST(FuncNameInferrerEscaped) {
TEST(RegressionLazyFunctionWithErrorWithArg) {
// Test only applies when lazy parsing.
if (!i::FLAG_lazy || (i::FLAG_ignition && i::FLAG_ignition_eager)) return;
if (!i::FLAG_lazy) return;
// The bug occurred when a lazy function had an error which requires a
// parameter (such as "unknown label" here). The error message was processed

2
test/cctest/test-profile-generator.cc
View File

@ -684,7 +684,7 @@ TEST(LineNumber) {
profiler.processor()->StopSynchronously();
bool is_lazy = i::FLAG_lazy && !(i::FLAG_ignition && i::FLAG_ignition_eager);
bool is_lazy = i::FLAG_lazy;
CHECK_EQ(1, GetFunctionLineNumber(profiler, env, "foo_at_the_first_line"));
CHECK_EQ(is_lazy ? 0 : 4,
GetFunctionLineNumber(profiler, env, "lazy_func_at_forth_line"));