[mac][asan][tests] Fix inspector/runtime/remote-object
Since one of the latest Clang rolls, ASan builds on MacOS appear to be using bigger stack frames, so reduce the maximum recursion depth a bit in that configuration. Fixed: v8:11176 Change-Id: I00942194a6c4d8046ec6abd24219912ebd153e57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2563465 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#71501}
This commit is contained in:
parent
2bbf333379
commit
ea750ba61d
@ -215,7 +215,13 @@ Response toProtocolValue(v8::Local<v8::Context> context,
|
||||
v8::Local<v8::Value> value,
|
||||
std::unique_ptr<protocol::Value>* result) {
|
||||
if (value->IsUndefined()) return Response::Success();
|
||||
return toProtocolValue(context, value, 1000, result);
|
||||
#if defined(V8_USE_ADDRESS_SANITIZER) && V8_OS_MACOSX
|
||||
// For whatever reason, ASan on MacOS has bigger stack frames.
|
||||
static const int kMaxDepth = 900;
|
||||
#else
|
||||
static const int kMaxDepth = 1000;
|
||||
#endif
|
||||
return toProtocolValue(context, value, kMaxDepth, result);
|
||||
}
|
||||
|
||||
enum AbbreviateMode { kMiddle, kEnd };
|
||||
|
@ -170,9 +170,6 @@
|
||||
# There are still memory leaks in some inspector tests
|
||||
# (https://crbug.com/v8/11107).
|
||||
'runtime/evaluate-async': [SKIP],
|
||||
|
||||
# https://crbug.com/v8/11176.
|
||||
'runtime/remote-object' : [SKIP],
|
||||
}], # asan == True
|
||||
|
||||
]
|
||||
|
Loading…
Reference in New Issue
Block a user