AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[tracing] Log detailed information via "v8.turbofan" category.

Browse Source 
The details of the TurboFan pipeline stages are probably not relevant to
most users of the "disabled-by-default-v8.compile" category, so we now
log them to "disabled-by-default-v8.turbofan" category instead.

Bug: v8:8598, v8:9039
Change-Id: Ib451f163f74eb11ffbeb0dc6f2ee590208bd296b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538135
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60455}
This commit is contained in:
Benedikt Meurer 2019-03-25 19:56:59 +01:00 committed by Commit Bot
parent 5c765ce405
commit ea7b41ce34
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/compiler/pipeline-statistics.cc
View File

@ -18,9 +18,9 @@ namespace compiler {
namespace { namespace {
// We log detailed phase information about the pipeline // We log detailed phase information about the pipeline
// in both the v8.compile and the v8.wasm categories. // in both the v8.turbofan and the v8.wasm categories.
const char kTraceCategory[] = // -- const char kTraceCategory[] = // --
TRACE_DISABLED_BY_DEFAULT("v8.compile") "," // -- TRACE_DISABLED_BY_DEFAULT("v8.turbofan") "," // --
TRACE_DISABLED_BY_DEFAULT("v8.wasm"); TRACE_DISABLED_BY_DEFAULT("v8.wasm");
} // namespace } // namespace

2
src/compiler/pipeline.cc
View File

@ -796,7 +796,7 @@ PipelineStatistics* CreatePipelineStatistics(Handle<Script> script,
PipelineStatistics* pipeline_statistics = nullptr; PipelineStatistics* pipeline_statistics = nullptr;
bool tracing_enabled; bool tracing_enabled;
TRACE_EVENT_CATEGORY_GROUP_ENABLED(TRACE_DISABLED_BY_DEFAULT("v8.compile"), TRACE_EVENT_CATEGORY_GROUP_ENABLED(TRACE_DISABLED_BY_DEFAULT("v8.turbofan"),
&tracing_enabled); &tracing_enabled);
if (tracing_enabled || FLAG_turbo_stats || FLAG_turbo_stats_nvp) { if (tracing_enabled || FLAG_turbo_stats || FLAG_turbo_stats_nvp) {
pipeline_statistics = pipeline_statistics =