From eacdc876e914a97d36f82e303f1fd50c9ae30835 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Gro=C3=9F?= Date: Fri, 25 Nov 2022 13:34:59 +0000 Subject: [PATCH] [sandbox] Remove v8_enable_sandbox_future MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit As this is by now equivalent to v8_enable_sandbox. Bug: v8:10391 Change-Id: I1eef40a86b984a1867de3513a108ece0d43ec394 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4055273 Commit-Queue: Samuel Groß Reviewed-by: Igor Sheludko Cr-Commit-Position: refs/heads/main@{#84494} --- BUILD.gn | 8 -------- 1 file changed, 8 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index d1db81a2f4..83c2fa2025 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -310,9 +310,6 @@ declare_args() { # Sets -DV8_ENABLE_SANDBOX. v8_enable_sandbox = "" - # Enable all available sandbox features. Implies v8_enable_sandbox. - v8_enable_sandbox_future = false - # Expose the memory corruption API to JavaScript. Useful for testing the sandbox. # WARNING This will expose builtins that (by design) cause memory corruption. # Sets -DV8_EXPOSE_MEMORY_CORRUPTION_API @@ -525,11 +522,6 @@ if (v8_enable_sandbox == "") { v8_enable_external_code_space && target_os != "fuchsia" } -# Enable all available sandbox features if sandbox future is enabled. -if (v8_enable_sandbox_future) { - v8_enable_sandbox = true -} - assert(!v8_disable_write_barriers || v8_enable_single_generation, "Disabling write barriers works only with single generation")