AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Explicitly constructing the std::pair

Browse Source 
older gcc compilers (tested on PPC gcc 6) may throw
a compilation error if std::pair is not constructed explicitly.

<algorithm> header also needs to be included to avoid the following
error:

error: 'remove_if' is not a member of 'std'


Change-Id: Ia7919185614fee1e2e35f2fb25f5fdf05b90e27f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2149565
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#67133}
This commit is contained in:
Milad Farazmand 2020-04-14 18:07:45 +00:00 committed by Commit Bot
parent 1171a5fcfa
commit ead618170b
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/heap/cppgc/page-memory.cc
View File

@ -195,7 +195,7 @@ Address PageBackend::AllocateLargePageMemory(size_t size) {
const PageMemory pm = pmr->GetPageMemory();
Unprotect(allocator_, pm);
page_memory_region_tree_.Add(pmr.get());
large_page_memory_regions_.insert({pmr.get(), std::move(pmr)});
large_page_memory_regions_.insert(std::make_pair(pmr.get(), std::move(pmr)));
return pm.writeable_region().base();
}

1
src/heap/cppgc/prefinalizer-handler.cc
View File

@ -4,6 +4,7 @@
#include "src/heap/cppgc/prefinalizer-handler.h"
#include <algorithm>
#include <memory>
#include "src/base/platform/platform.h"