Add infra-staging flag to test runner
Add infra-staging flag to test runner which adds the no-fail flag. This will be used to see the accuracy of numfuzz builders when we ignore exit code 1. Bug: v8:11826 Change-Id: I6684331efe9c801d02716d94cb16e8ba816d9c68 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3110196 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#76409}
This commit is contained in:
parent
340a114cf4
commit
eae0a9a390
@ -268,6 +268,7 @@ class BaseTestRunner(object):
|
||||
self.build_config = None
|
||||
self.mode_options = None
|
||||
self.target_os = None
|
||||
self.infra_staging = False
|
||||
|
||||
@property
|
||||
def framework_name(self):
|
||||
@ -280,6 +281,7 @@ class BaseTestRunner(object):
|
||||
try:
|
||||
parser = self._create_parser()
|
||||
options, args = self._parse_args(parser, sys_args)
|
||||
self.infra_staging = options.infra_staging
|
||||
if options.swarming:
|
||||
# Swarming doesn't print how isolated commands are called. Lets make
|
||||
# this less cryptic by printing it ourselves.
|
||||
@ -349,6 +351,13 @@ class BaseTestRunner(object):
|
||||
help="How long should fuzzer run")
|
||||
parser.add_option("--swarming", default=False, action="store_true",
|
||||
help="Indicates running test driver on swarming.")
|
||||
parser.add_option('--infra-staging', help='Use new test runner features',
|
||||
dest='infra_staging', default=None,
|
||||
action='store_true')
|
||||
parser.add_option('--no-infra-staging',
|
||||
help='Opt out of new test runner features',
|
||||
dest='infra_staging', default=None,
|
||||
action='store_false')
|
||||
|
||||
parser.add_option("-j", help="The number of parallel tasks to run",
|
||||
default=0, type=int)
|
||||
|
@ -124,7 +124,10 @@ class NumFuzzer(base_runner.BaseTestRunner):
|
||||
|
||||
def _runner_flags(self):
|
||||
"""Extra default flags specific to the test runner implementation."""
|
||||
return ['--no-abort-on-contradictory-flags']
|
||||
flags = ['--no-abort-on-contradictory-flags']
|
||||
if self.infra_staging:
|
||||
flags.append('--no-fail')
|
||||
return flags
|
||||
|
||||
def _get_statusfile_variables(self, options):
|
||||
variables = (
|
||||
|
@ -132,13 +132,6 @@ class StandardTestRunner(base_runner.BaseTestRunner):
|
||||
parser.add_option('--cfi-vptr',
|
||||
help='Run tests with UBSAN cfi_vptr option.',
|
||||
default=False, action='store_true')
|
||||
parser.add_option('--infra-staging', help='Use new test runner features',
|
||||
dest='infra_staging', default=None,
|
||||
action='store_true')
|
||||
parser.add_option('--no-infra-staging',
|
||||
help='Opt out of new test runner features',
|
||||
dest='infra_staging', default=None,
|
||||
action='store_false')
|
||||
parser.add_option('--no-sorting', '--nosorting',
|
||||
help='Don\'t sort tests according to duration of last'
|
||||
' run.',
|
||||
|
Loading…
Reference in New Issue
Block a user