From eaf033132a932f304e57de837c8429013bdab791 Mon Sep 17 00:00:00 2001 From: pthier Date: Fri, 25 Nov 2022 13:15:15 +0100 Subject: [PATCH] [heap] Enable string shortcutting with stack per default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Disabling string shortcutting during GCs with stack caused regressions (mainly on RegExp and typescript benchmarks). Enable shortcutting per default (again). Bug: chromium:1393572 Change-Id: Idcf7f3f6e74263a94d9303c93b66c7ed4e20a9cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4055272 Auto-Submit: Patrick Thier Commit-Queue: Dominik Inführ Reviewed-by: Dominik Inführ Cr-Commit-Position: refs/heads/main@{#84500} --- src/flags/flag-definitions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index ecbbbfd05d..73bbbe695e 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -1446,7 +1446,7 @@ DEFINE_BOOL(compact_with_stack, true, DEFINE_BOOL( compact_code_space_with_stack, true, "Perform code space compaction when finalizing a full GC with stack") -DEFINE_BOOL(shortcut_strings_with_stack, false, +DEFINE_BOOL(shortcut_strings_with_stack, true, "Shortcut Strings during GC with stack") DEFINE_BOOL(stress_compaction, false, "Stress GC compaction to flush out bugs (implies "