AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Use return value of GetPropertyAttributes to make compiler happy.

Browse Source 
BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/420443006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
hpayer@chromium.org 2014-07-28 12:00:05 +00:00
parent 82078339b3
commit eb7c55651b
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/objects.cc
View File

@ -4093,7 +4093,8 @@ void JSObject::AddProperty(Handle<JSObject> object, Handle<Name> name,
ASSERT(!object->IsJSProxy()); ASSERT(!object->IsJSProxy());
ASSERT(!name->AsArrayIndex(&index)); ASSERT(!name->AsArrayIndex(&index));
LookupIterator it(object, name, LookupIterator::CHECK_OWN_REAL); LookupIterator it(object, name, LookupIterator::CHECK_OWN_REAL);
GetPropertyAttributes(&it); Maybe<PropertyAttributes> maybe = GetPropertyAttributes(&it);
ASSERT(maybe.has_value);
ASSERT(!it.IsFound()); ASSERT(!it.IsFound());
ASSERT(object->map()->is_extensible()); ASSERT(object->map()->is_extensible());
#endif #endif

6
src/runtime.cc
View File

@ -5251,7 +5251,8 @@ RUNTIME_FUNCTION(Runtime_AddNamedProperty) {
uint32_t index = 0; uint32_t index = 0;
ASSERT(!key->ToArrayIndex(&index)); ASSERT(!key->ToArrayIndex(&index));
LookupIterator it(object, key, LookupIterator::CHECK_OWN_REAL); LookupIterator it(object, key, LookupIterator::CHECK_OWN_REAL);
JSReceiver::GetPropertyAttributes(&it); Maybe<PropertyAttributes> maybe = JSReceiver::GetPropertyAttributes(&it);
ASSERT(maybe.has_value);
RUNTIME_ASSERT(!it.IsFound()); RUNTIME_ASSERT(!it.IsFound());
#endif #endif
@ -5282,7 +5283,8 @@ RUNTIME_FUNCTION(Runtime_AddPropertyForTemplate) {
if (key->IsName()) { if (key->IsName()) {
LookupIterator it(object, Handle<Name>::cast(key), LookupIterator it(object, Handle<Name>::cast(key),
LookupIterator::CHECK_OWN_REAL); LookupIterator::CHECK_OWN_REAL);
JSReceiver::GetPropertyAttributes(&it); Maybe<PropertyAttributes> maybe = JSReceiver::GetPropertyAttributes(&it);
ASSERT(maybe.has_value);
duplicate = it.IsFound(); duplicate = it.IsFound();
} else { } else {
uint32_t index = 0; uint32_t index = 0;