From ec3731d7f7cb65de2d6ba1733d753f482926a6e7 Mon Sep 17 00:00:00 2001 From: Richard Townsend Date: Wed, 8 Apr 2020 14:51:14 +0100 Subject: [PATCH] [arm64] fix: PushAllRegistersAndIterateStack name for Windows on Arm Bug: v8:10407 Change-Id: I4fb6544ca575e115ed84c1e15911794f3fb4a627 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144112 Reviewed-by: Michael Lippautz Commit-Queue: Richard Townsend Cr-Commit-Position: refs/heads/master@{#67089} --- src/heap/cppgc/asm/arm64/push_registers_asm.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/heap/cppgc/asm/arm64/push_registers_asm.cc b/src/heap/cppgc/asm/arm64/push_registers_asm.cc index fd4d1da6b1..9597dac86a 100644 --- a/src/heap/cppgc/asm/arm64/push_registers_asm.cc +++ b/src/heap/cppgc/asm/arm64/push_registers_asm.cc @@ -15,15 +15,13 @@ // // Calling convention source: // https://en.wikipedia.org/wiki/Calling_convention#ARM_(A64) + asm( -#ifdef _WIN64 - ".globl _PushAllRegistersAndIterateStack \n" - "_PushAllRegistersAndIterateStack: \n" -#else // !_WIN64 ".globl PushAllRegistersAndIterateStack \n" +#ifndef _WIN64 ".hidden PushAllRegistersAndIterateStack \n" +#endif "PushAllRegistersAndIterateStack: \n" -#endif // !_WIN64 // x19-x29 are callee-saved. " stp x19, x20, [sp, #-16]! \n" " stp x21, x22, [sp, #-16]! \n"