AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Make Object::GetIdentityHash() never return 0.

Browse Source 
This is convenient when using identity hashes in data structures that
want to reserve 0 as a sentinel value, such as WebKit's WTF::HashMap.

Review URL: http://codereview.chromium.org/100147

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@1821 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
asargent@chromium.org 2009-04-29 21:44:13 +00:00
parent 976a9025e4
commit ec3beee2bf
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/api.cc
View File

@ -2072,7 +2072,12 @@ int v8::Object::GetIdentityHash() {
if (hash->IsSmi()) {
hash_value = i::Smi::cast(*hash)->value();
} else {
hash_value = random() & i::Smi::kMaxValue; // Limit range to fit a smi.
int attempts = 0;
do {
hash_value = random() & i::Smi::kMaxValue; // Limit range to fit a smi.
attempts++;
} while (hash_value == 0 && attempts < 30);
hash_value = hash_value != 0 ? hash_value : 1; // never return 0
i::SetProperty(hidden_props,
hash_symbol,
i::Handle<i::Object>(i::Smi::FromInt(hash_value)),