AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Fix and re-enable tests requiring specific optimization timing

Browse Source 
We now have %FinalizeOptimization() to block until all concurrent
compile jobs are done.

Bug: v8:7790,v8:12004
Change-Id: Ibb9955be06957b3f395b680e9be570c7c3ec0dcb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086478
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#76231}
This commit is contained in:
Jakob Gruber 2021-08-11 11:10:15 +02:00 committed by V8 LUCI CQ
parent bd3a354aeb
commit ec85051385
3 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
test/mjsunit/interrupt-budget-override.js
View File

@ -16,4 +16,5 @@ function f() {
f();
f();
f();
%FinalizeOptimization();
assertOptimized(f);

6
test/mjsunit/mjsunit.status
View File

@ -207,12 +207,6 @@
'regress/regress-crbug-941743': [PASS, HEAVY],
'regress/regress-crbug-1191886': [PASS, HEAVY],
'wasm/externref-globals': [PASS, HEAVY],
# Unpredictable results due to assertOptimized with concurrent optimization.
# TODO(v8:12004): Add a runtime function to flush the optimizing compile
# dispatcher *without* aborting existing jobs.
'interrupt-budget-override': [PASS,FAIL],
'never-optimize': [PASS,FAIL],
}], # ALWAYS
##############################################################################

1
test/mjsunit/never-optimize.js
View File

@ -43,5 +43,6 @@ for (let i = 0; i < 1000; ++i) {
u1();
u2();
}
%FinalizeOptimization();
assertUnoptimized(u1);
assertOptimized(u2);