AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Turn on i18n support by default", "Update test262 expectations, now that 15.5.4.9_CE passes", "Make testing i18n the default.", "Mark two failing mozilla tests as failing.", "Mark mozilla tests as flaky instead of failing" and "Fix test expectations for i18n."

Browse Source 
This reverts commit 16783-16788 due to several crashers on nosnap builder.

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/23455055

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16789 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
machenbach@chromium.org 2013-09-18 13:50:00 +00:00
parent ef62d7231e
commit eca42c42cb
10 changed files with 12 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Makefile
View File

@ -124,10 +124,9 @@ endif
ifeq ($(regexp), interpreted)
GYPFLAGS += -Dv8_interpreted_regexp=1
endif
# i18nsupport=off
ifeq ($(i18nsupport), off)
GYPFLAGS += -Dv8_enable_i18n_support=0
TESTFLAGS += --noi18n
# i18nsupport=on
ifeq ($(i18nsupport), on)
GYPFLAGS += -Dv8_enable_i18n_support=1
endif
# arm specific flags.
# armv7=false/true
@ -332,7 +331,7 @@ $(addsuffix .check, $(ANDROID_ARCHES)): \
$(addsuffix .check, $(NACL_BUILDS)): $$(basename $$@)
@tools/run-tests.py $(TESTJOBS) --outdir=$(OUTDIR) \
--arch-and-mode=$(basename $@) \
--timeout=600 --nopresubmit --noi18n \
--timeout=600 --nopresubmit \
--command-prefix="tools/nacl-run.py"
$(addsuffix .check, $(NACL_ARCHES)): \

3
Makefile.nacl
View File

@ -74,9 +74,6 @@ endif
# For mksnapshot host generation.
GYPENV += host_os=${HOST_OS}
# ICU doesn't support NaCl.
GYPENV += v8_enable_i18n_support=0
NACL_MAKEFILES = $(addprefix $(OUTDIR)/Makefile.,$(NACL_ARCHES))
.SECONDEXPANSION:
# For some reason the $$(basename $$@) expansion didn't work here...

2
build/features.gypi
View File

@ -54,7 +54,7 @@
# Enable ECMAScript Internationalization API. Enabling this feature will
# add a dependency on the ICU library.
'v8_enable_i18n_support%': 1,
'v8_enable_i18n_support%': 0,
},
'target_defaults': {
'conditions': [

2
build/standalone.gypi
View File

@ -36,7 +36,7 @@
'clang%': 0,
'visibility%': 'hidden',
'v8_enable_backtrace%': 0,
'v8_enable_i18n_support%': 1,
'v8_enable_i18n_support%': 0,
'msvs_multi_core_compile%': '1',
'mac_deployment_target%': '10.5',
'variables': {

2
samples/samples.gyp
View File

@ -28,7 +28,7 @@
{
'variables': {
'v8_code': 1,
'v8_enable_i18n_support%': 1,
'v8_enable_i18n_support%': 0,
},
'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
'target_defaults': {

2
src/d8.gyp
View File

@ -31,7 +31,7 @@
'console%': '',
# Enable support for Intel VTune. Supported on ia32/x64 only
'v8_enable_vtunejit%': 0,
'v8_enable_i18n_support%': 1,
'v8_enable_i18n_support%': 0,
},
'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
'targets': [

4
test/intl/intl.status
View File

@ -34,7 +34,3 @@ general/v8Intl-exists: FAIL
# TODO(jochen): The following test is flaky.
overrides/caching: PASS || FAIL
# TODO(jochen): These tests started to fail on mac after i18n support was
# turned on. Need to investigate why.
collator/default-locale: PASS || FAIL

6
test/mozilla/mozilla.status
View File

@ -45,12 +45,6 @@
prefix mozilla
def FAIL_OK = FAIL, OKAY
##################### NEEDS INVESTIGATION ##############
# BUG(2893): These tests started to fail after i18n support was turned on. Need
# to investigate why.
ecma_3/Number/15.7.4.3-02: PASS || FAIL
ecma_3/Date/15.9.5.5-02: PASS || FAIL
##################### SKIPPED TESTS #####################

7
test/test262/test262.status
View File

@ -36,9 +36,10 @@ def FAIL_OK = FAIL, OKAY
# V8 Bug: http://code.google.com/p/v8/issues/detail?id=691
11.2.3-3_3: FAIL
# BUG(2893): These tests started to fail after i18n support was turned on. Need
# to investigate why.
15.5.4.9_3: PASS || FAIL
# Strings that are considered canonically equivalent by the Unicode standard
# return a non-zero value on String.prototype.localeCompare calls.
# V8 Bug: http://code.google.com/p/v8/issues/detail?id=2413
15.5.4.9_CE: FAIL
##################### DELIBERATE INCOMPATIBILITIES #####################

5
tools/run-tests.py
View File

@ -112,9 +112,6 @@ def BuildOptions():
result.add_option("-m", "--mode",
help="The test modes in which to run (comma-separated)",
default="release,debug")
result.add_option("--no-i18n", "--noi18n",
help="Skip internationalization tests",
default=False, action="store_true")
result.add_option("--no-network", "--nonetwork",
help="Don't distribute tests on the network",
default=(utils.GuessOS() != "linux"),
@ -213,8 +210,6 @@ def ProcessOptions(options):
if not options.flaky_tests in ["run", "skip", "dontcare"]:
print "Unknown flaky test mode %s" % options.flaky_tests
return False
if not options.no_i18n:
DEFAULT_TESTS.append("intl")
return True