AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[maglev] CompactInterpreterFrameState fixes

Browse Source 
Bug: v8:7700
Change-Id: I1efa298a25bf15c104a57db3ec7cc4d7e36861eb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3553102
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Auto-Submit: Toon Verwaest <verwaest@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79655}
This commit is contained in:
Toon Verwaest 2022-03-25 15:01:30 +01:00 committed by V8 LUCI CQ
parent 0a110021d2
commit ecc3c6367f
2 changed files with 30 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/maglev/maglev-interpreter-frame-state.h
View File

@ -113,20 +113,20 @@ class CompactInterpreterFrameState {
template <typename Function> template <typename Function>
void ForEachLocal(const MaglevCompilationUnit& info, Function&& f) const { void ForEachLocal(const MaglevCompilationUnit& info, Function&& f) const {
int live_reg = 0;
for (int register_index : *liveness_) { for (int register_index : *liveness_) {
interpreter::Register reg = interpreter::Register(register_index); interpreter::Register reg = interpreter::Register(register_index);
f(live_registers_and_accumulator_[info.parameter_count() + f(live_registers_and_accumulator_[info.parameter_count() + live_reg++],
register_index],
reg); reg);
} }
} }
template <typename Function> template <typename Function>
void ForEachLocal(const MaglevCompilationUnit& info, Function&& f) { void ForEachLocal(const MaglevCompilationUnit& info, Function&& f) {
int live_reg = 0;
for (int register_index : *liveness_) { for (int register_index : *liveness_) {
interpreter::Register reg = interpreter::Register(register_index); interpreter::Register reg = interpreter::Register(register_index);
f(live_registers_and_accumulator_[info.parameter_count() + f(live_registers_and_accumulator_[info.parameter_count() + live_reg++],
register_index],
reg); reg);
} }
} }
@ -134,7 +134,7 @@ class CompactInterpreterFrameState {
template <typename Function> template <typename Function>
void ForAccumulator(const MaglevCompilationUnit& info, Function&& f) { void ForAccumulator(const MaglevCompilationUnit& info, Function&& f) {
if (liveness_->AccumulatorIsLive()) { if (liveness_->AccumulatorIsLive()) {
f(live_registers_and_accumulator_[0]); f(live_registers_and_accumulator_[SizeFor(info, liveness_) - 1]);
} }
} }

25
test/mjsunit/maglev/19.js Normal file
View File

@ -0,0 +1,25 @@
// Copyright 2022 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Flags: --allow-natives-syntax --maglev
function f(i) {
var j;
var o;
if (i) {
} else {
if (j) {
} else {
}
}
return o;
}
%PrepareFunctionForOptimization(f);
f(false, true);
%OptimizeMaglevOnNextCall(f);
f(false, true);
f(false, true);
f(false, true);