Revert "Remove SetForceInlineFlag from src/js/*"
This reverts commit ae9a2d38f3
.
Reason for revert: Regresses benchmarks related to maps and sets.
Regressions here: https://chromeperf.appspot.com/group_report?rev=46756.
In future when we move these builtins to CSA, we may still want to
remove this flag.
Original change's description:
> Remove SetForceInlineFlag from src/js/*
>
> Remove SetForceInlineFlag from the js builtins.
>
> Bug:
> Change-Id: I962982509c82e4baba8dc32a0f163147c47daf34
> Reviewed-on: https://chromium-review.googlesource.com/571803
> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
> Commit-Queue: Mythri Alle <mythria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#46756}
TBR=rmcilroy@chromium.org,jarin@chromium.org,mythria@chromium.org,bmeurer@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I96651aa9d6e91e593af8da1b531e9f7b0240088f
Reviewed-on: https://chromium-review.googlesource.com/579194
Commit-Queue: Mythri Alle <mythria@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#46797}
This commit is contained in:
parent
8580529302
commit
ecd06ed09f
@ -30,6 +30,7 @@ function HashToEntry(table, hash, numBuckets) {
|
||||
var bucket = ORDERED_HASH_TABLE_HASH_TO_BUCKET(hash, numBuckets);
|
||||
return ORDERED_HASH_TABLE_BUCKET_AT(table, bucket);
|
||||
}
|
||||
%SetForceInlineFlag(HashToEntry);
|
||||
|
||||
|
||||
function SetFindEntry(table, numBuckets, key, hash) {
|
||||
@ -49,6 +50,7 @@ function SetFindEntry(table, numBuckets, key, hash) {
|
||||
}
|
||||
return NOT_FOUND;
|
||||
}
|
||||
%SetForceInlineFlag(SetFindEntry);
|
||||
|
||||
|
||||
function MapFindEntry(table, numBuckets, key, hash) {
|
||||
@ -68,6 +70,7 @@ function MapFindEntry(table, numBuckets, key, hash) {
|
||||
}
|
||||
return NOT_FOUND;
|
||||
}
|
||||
%SetForceInlineFlag(MapFindEntry);
|
||||
|
||||
|
||||
function ComputeIntegerHash(key, seed) {
|
||||
@ -81,6 +84,7 @@ function ComputeIntegerHash(key, seed) {
|
||||
hash = hash ^ (hash >>> 16);
|
||||
return hash & 0x3fffffff;
|
||||
}
|
||||
%SetForceInlineFlag(ComputeIntegerHash);
|
||||
|
||||
function GetExistingHash(key) {
|
||||
if (%_IsSmi(key)) {
|
||||
@ -97,6 +101,7 @@ function GetExistingHash(key) {
|
||||
}
|
||||
return %GenericHash(key);
|
||||
}
|
||||
%SetForceInlineFlag(GetExistingHash);
|
||||
|
||||
|
||||
function GetHash(key) {
|
||||
@ -108,6 +113,7 @@ function GetHash(key) {
|
||||
}
|
||||
return hash;
|
||||
}
|
||||
%SetForceInlineFlag(GetHash);
|
||||
|
||||
|
||||
// -------------------------------------------------------------------
|
||||
|
2
src/js/max-min.js
vendored
2
src/js/max-min.js
vendored
@ -16,6 +16,8 @@ function MinSimple(a, b) {
|
||||
return a > b ? b : a;
|
||||
}
|
||||
|
||||
%SetForceInlineFlag(MaxSimple);
|
||||
%SetForceInlineFlag(MinSimple);
|
||||
|
||||
// ----------------------------------------------------------------------------
|
||||
// Exports
|
||||
|
@ -247,6 +247,7 @@ TYPED_ARRAYS(TYPED_ARRAY_SUBARRAY_CASE)
|
||||
"get %TypedArray%.prototype.subarray", this);
|
||||
}
|
||||
);
|
||||
%SetForceInlineFlag(GlobalTypedArray.prototype.subarray);
|
||||
|
||||
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user