AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Reland "[embedded-builtins] Enable on all arches except x86 for benchmarks"

Browse Source 
This is a reland of f5a8352b0f

Original change's description:
> [embedded-builtins] Enable on all arches except x86 for benchmarks
> 
> This CL enables embedded builtins to get benchmark feedback. We need
> this feedback to identify and address remaining performance problems.
> 
> Bug: v8:6666
> Change-Id: I8f77f218e656b55ddabe1236eb2a1d14a5ac6233
> Reviewed-on: https://chromium-review.googlesource.com/1105834
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#53836}

Bug: v8:6666
Change-Id: Idd736f3ec06a7ea57e53a666fd5434e32ca316ad
Reviewed-on: https://chromium-review.googlesource.com/1148100
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54730}
This commit is contained in:
Sigurd Schneider 2018-06-19 12:52:53 +02:00 committed by Commit Bot
parent 2fffcaa11d
commit ecd855b499
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BUILD.gn
View File

@ -73,10 +73,8 @@ declare_args() {
# Enable embedded builtins.
# TODO(jgruber,v8:6666): Support ia32 and maybe MSVC.
# TODO(jgruber,v8:6666): Enable for remaining architectures once performance
# regressions are addressed.
v8_enable_embedded_builtins =
v8_use_snapshot && v8_current_cpu == "x64" && (!is_win || is_clang)
v8_use_snapshot && v8_current_cpu != "x86" && (!is_win || is_clang)
# Enable code-generation-time checking of types in the CodeStubAssembler.
v8_enable_verify_csa = false