AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix bogus allocation limit in allocation folding.

Browse Source 
R=ishell@chromium.org
TEST=mjsunit/allocation-folding

Review URL: https://codereview.chromium.org/73563004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17805 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
mstarzinger@chromium.org 2013-11-15 18:44:59 +00:00
parent 4ed2538262
commit ed034b39e5
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hydrogen-instructions.cc
View File

@ -3404,7 +3404,7 @@ void HAllocate::HandleSideEffectDominator(GVNFlag side_effect,
}
}
if (new_dominator_size > Page::kMaxNonCodeHeapObjectSize) {
if (new_dominator_size > isolate()->heap()->MaxRegularSpaceAllocationSize()) {
if (FLAG_trace_allocation_folding) {
PrintF("#%d (%s) cannot fold into #%d (%s) due to size: %d\n",
id(), Mnemonic(), dominator_allocate->id(),

14
test/mjsunit/allocation-folding.js
View File

@ -100,3 +100,17 @@ gc();
assertEquals(result[1], 4);
assertEquals(result2[1], 6);
// Test to exceed the Heap::MaxRegularSpaceAllocationSize limit but not
// the Page::kMaxNonCodeHeapObjectSize limit with allocation folding.
function boom() {
var a1 = new Array(84632);
var a2 = new Array(84632);
var a3 = new Array(84632);
return [ a1, a2, a3 ];
}
boom(); boom(); boom();
%OptimizeFunctionOnNextCall(boom);
boom();