AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix bad reinterpret_cast of StringFromCodePointOperator

Browse Source 
StringFromCodePointOperator needed to derive from Operator1<UnicodeEncoding>
rather than plain old Operator. This was thankfully caught by the CFI build.

R=bmeurer@chromium.org, caitp@chromium.org
BUG=v8:5498

Review-Url: https://codereview.chromium.org/2398403003
Cr-Commit-Position: refs/heads/master@{#40131}
This commit is contained in:
adamk 2016-10-10 09:58:39 -07:00 committed by Commit bot
parent 7d336218bf
commit ed45f5903c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/simplified-operator.cc
View File

@ -474,10 +474,11 @@ struct SimplifiedOperatorGlobalCache final {
#undef CHECKED
template <UnicodeEncoding kEncoding>
struct StringFromCodePointOperator final : public Operator {
struct StringFromCodePointOperator final : public Operator1<UnicodeEncoding> {
StringFromCodePointOperator()
: Operator(IrOpcode::kStringFromCodePoint, Operator::kPure,
"StringFromCodePoint", 1, 0, 0, 1, 0, 0) {}
: Operator1<UnicodeEncoding>(IrOpcode::kStringFromCodePoint,
Operator::kPure, "StringFromCodePoint", 1,
0, 0, 1, 0, 0, kEncoding) {}
};
StringFromCodePointOperator<UnicodeEncoding::UTF16>
kStringFromCodePointOperatorUTF16;