AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Remove dead %IsDebugActive() runtime function/intrinsic.

Browse Source 
This is not used at all anymore and can thus be removed.

Bug: v8:8015
Change-Id: Ifebe576dd84cbdbd77bf9ca54d479050e3174d2b
Reviewed-on: https://chromium-review.googlesource.com/1235920
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56073}
This commit is contained in:
Benedikt Meurer 2018-09-20 13:21:01 +02:00 committed by Commit Bot
parent 3a9466a89c
commit ed9551eba4
3 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/compiler/js-intrinsic-lowering.cc
View File

@ -32,8 +32,6 @@ Reduction JSIntrinsicLowering::Reduce(Node* node) {
switch (f->function_id) { switch (f->function_id) {
case Runtime::kInlineCreateIterResultObject: case Runtime::kInlineCreateIterResultObject:
return ReduceCreateIterResultObject(node); return ReduceCreateIterResultObject(node);
case Runtime::kInlineDebugIsActive:
return ReduceDebugIsActive(node);
case Runtime::kInlineDeoptimizeNow: case Runtime::kInlineDeoptimizeNow:
return ReduceDeoptimizeNow(node); return ReduceDeoptimizeNow(node);
case Runtime::kInlineGeneratorClose: case Runtime::kInlineGeneratorClose:
@ -92,16 +90,6 @@ Reduction JSIntrinsicLowering::ReduceCreateIterResultObject(Node* node) {
context, effect); context, effect);
} }
Reduction JSIntrinsicLowering::ReduceDebugIsActive(Node* node) {
Node* const value = jsgraph()->ExternalConstant(
ExternalReference::debug_is_active_address(isolate()));
Node* const effect = NodeProperties::GetEffectInput(node);
Node* const control = NodeProperties::GetControlInput(node);
Operator const* const op =
simplified()->LoadField(AccessBuilder::ForExternalUint8Value());
return Change(node, op, value, effect, control);
}
Reduction JSIntrinsicLowering::ReduceDeoptimizeNow(Node* node) { Reduction JSIntrinsicLowering::ReduceDeoptimizeNow(Node* node) {
Node* const frame_state = NodeProperties::GetFrameStateInput(node); Node* const frame_state = NodeProperties::GetFrameStateInput(node);
Node* const effect = NodeProperties::GetEffectInput(node); Node* const effect = NodeProperties::GetEffectInput(node);

5
src/runtime/runtime-debug.cc
View File

@ -641,11 +641,6 @@ RUNTIME_FUNCTION(Runtime_DebugPopPromise) {
return ReadOnlyRoots(isolate).undefined_value(); return ReadOnlyRoots(isolate).undefined_value();
} }
RUNTIME_FUNCTION(Runtime_DebugIsActive) {
SealHandleScope shs(isolate);
return Smi::FromInt(isolate->debug()->is_active());
}
namespace { namespace {
Handle<JSObject> MakeRangeObject(Isolate* isolate, const CoverageBlock& range) { Handle<JSObject> MakeRangeObject(Isolate* isolate, const CoverageBlock& range) {
Factory* factory = isolate->factory(); Factory* factory = isolate->factory();

1
src/runtime/runtime.h
View File

@ -128,7 +128,6 @@ namespace internal {
F(DebugBreakAtEntry, 1, 1) \ F(DebugBreakAtEntry, 1, 1) \
F(DebugCollectCoverage, 0, 1) \ F(DebugCollectCoverage, 0, 1) \
F(DebugGetLoadedScriptIds, 0, 1) \ F(DebugGetLoadedScriptIds, 0, 1) \
F(DebugIsActive, 0, 1) \
F(DebugOnFunctionCall, 2, 1) \ F(DebugOnFunctionCall, 2, 1) \
F(DebugPopPromise, 0, 1) \ F(DebugPopPromise, 0, 1) \
F(DebugPrepareStepInSuspendedGenerator, 0, 1) \ F(DebugPrepareStepInSuspendedGenerator, 0, 1) \