AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[debug][cleanup] Using 'using' instead of 'typedef'

Browse Source 
Even though both are allowed in the style guide, it recommends to use
'using', as its syntax is more consistent with the rest of C++.
This CL turns all typedefs in src/debug to 'using' declarations.

R=jgruber@chromium.org

Bug: v8:8834
Change-Id: I205e14a0b230a26119e5b209a2bcec493a8815e3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545901
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60698}
This commit is contained in:
Clemens Hammacher 2019-03-29 13:41:32 +01:00 committed by Commit Bot
parent 2322b9a8ca
commit ede4557491
5 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/debug/debug-coverage.cc
View File

@ -21,7 +21,7 @@ class SharedToCounterMap
base::KeyEqualityMatcher<Object>,
base::DefaultAllocationPolicy> {
public:
typedef base::TemplateHashMapEntry<SharedFunctionInfo, uint32_t> Entry;
using Entry = base::TemplateHashMapEntry<SharedFunctionInfo, uint32_t>;
inline void Add(SharedFunctionInfo key, uint32_t count) {
Entry* entry = LookupOrInsert(key, Hash(key), []() { return 0; });
uint32_t old_count = entry->value;

6
src/debug/debug-evaluate.cc
View File

@ -374,8 +374,8 @@ bool IntrinsicHasNoSideEffect(Runtime::FunctionId id) {
}
bool BytecodeHasNoSideEffect(interpreter::Bytecode bytecode) {
typedef interpreter::Bytecode Bytecode;
typedef interpreter::Bytecodes Bytecodes;
using interpreter::Bytecode;
using interpreter::Bytecodes;
if (Bytecodes::IsWithoutExternalSideEffects(bytecode)) return true;
if (Bytecodes::IsCallOrConstruct(bytecode)) return true;
if (Bytecodes::IsJumpIfToBoolean(bytecode)) return true;
@ -824,7 +824,7 @@ DebugInfo::SideEffectState BuiltinGetSideEffectState(Builtins::Name id) {
}
bool BytecodeRequiresRuntimeCheck(interpreter::Bytecode bytecode) {
typedef interpreter::Bytecode Bytecode;
using interpreter::Bytecode;
switch (bytecode) {
case Bytecode::kStaNamedProperty:
case Bytecode::kStaNamedPropertyNoFeedback:

4
src/debug/debug-scopes.h
View File

@ -128,8 +128,8 @@ class ScopeIterator {
void UnwrapEvaluationContext();
typedef std::function<bool(Handle<String> name, Handle<Object> value)>
Visitor;
using Visitor =
std::function<bool(Handle<String> name, Handle<Object> value)>;
Handle<JSObject> WithContextExtension();

2
src/debug/debug.h
View File

@ -449,7 +449,7 @@ class V8_EXPORT_PRIVATE Debug {
void ClearAllDebuggerHints();
// Wraps logic for clearing and maybe freeing all debug infos.
typedef std::function<void(Handle<DebugInfo>)> DebugInfoClearFunction;
using DebugInfoClearFunction = std::function<void(Handle<DebugInfo>)>;
void ClearAllDebugInfos(const DebugInfoClearFunction& clear_function);
void FindDebugInfo(Handle<DebugInfo> debug_info, DebugInfoListNode** prev,

2
src/debug/interface-types.h
View File

@ -194,7 +194,7 @@ class ConsoleDelegate {
virtual ~ConsoleDelegate() = default;
};
typedef int BreakpointId;
using BreakpointId = int;
} // namespace debug
} // namespace v8