From edef59ca27b038dd9e14bc4373fc6250552cc3ed Mon Sep 17 00:00:00 2001 From: jgruber Date: Thu, 28 Jun 2018 11:23:06 +0200 Subject: [PATCH] Reland "[build] Disable slow asserts for v8_enable_fast_mksnapshot" This is a reland of 7a0d6a50005cb96138eda849abc8b5aa45430509 Original change's description: > [build] Disable slow asserts for v8_enable_fast_mksnapshot > > Slow asserts double the time spent in mksnapshot. While we want them > enabled on our bot builds, local builds should be fast and don't > necessarily need them. > > This also adds v8_enable_fast_mksnapshot as default in gm.py. > > Bug: v8:7891,v8:6688 > Change-Id: I5ab1491f3396c4351de30dbbb80a81e2242c5db9 > Reviewed-on: https://chromium-review.googlesource.com/1116552 > Reviewed-by: Jakob Kummerow > Commit-Queue: Jakob Gruber > Cr-Commit-Position: refs/heads/master@{#54074} TBR=jkummerow@chromium.org Bug: v8:7891, v8:6688 Change-Id: I3b1e80b3ca156b7d571ebc7f04e341f0ba716691 Reviewed-on: https://chromium-review.googlesource.com/1118139 Reviewed-by: Jakob Gruber Commit-Queue: Jakob Gruber Cr-Commit-Position: refs/heads/master@{#54080} --- BUILD.gn | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 7754ca9b11..b16364a428 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -1062,6 +1062,11 @@ template("run_mksnapshot") { "--no-turbo-rewrite-far-jumps", "--no-turbo-verify-allocation", ] + + if (v8_enable_debugging_features && v8_enable_slow_dchecks) { + # mksnapshot only accepts this flag if ENABLE_SLOW_DCHECKS is defined. + args += [ "--no-enable-slow-asserts" ] + } } } }