AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Fix DCHECK in NewSpace::Grow

Browse Source 
NewSpace::Grow isn't in a safepoint when FLAG_local_heaps is disabled.

Bug: chromium:1136292
Change-Id: I18c4d42b73450d11ce9b685276b239481a4c5c83
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2459372
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70397}
This commit is contained in:
Dominik Inführ 2020-10-08 08:48:07 +02:00 committed by Commit Bot
parent f56bfe8520
commit ee3df92b90
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/heap/new-spaces.cc
View File

@ -418,7 +418,7 @@ void NewSpace::TearDown() {
void NewSpace::Flip() { SemiSpace::Swap(&from_space_, &to_space_); } void NewSpace::Flip() { SemiSpace::Swap(&from_space_, &to_space_); }
void NewSpace::Grow() { void NewSpace::Grow() {
DCHECK(heap()->safepoint()->IsActive()); DCHECK_IMPLIES(FLAG_local_heaps, heap()->safepoint()->IsActive());
// Double the semispace size but only up to maximum capacity. // Double the semispace size but only up to maximum capacity.
DCHECK(TotalCapacity() < MaximumCapacity()); DCHECK(TotalCapacity() < MaximumCapacity());
size_t new_capacity = size_t new_capacity =