AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Remove obsolete always-on flag --inline-into-try

Browse Source 
Change-Id: Ib1233607236c991af0125f0197b9f89b10b4519d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625990
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61779}
This commit is contained in:
Georg Neis 2019-05-22 20:50:16 +02:00 committed by Commit Bot
parent f589d56101
commit ee687e4325
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/compiler/js-inlining.cc
View File

@ -403,18 +403,8 @@ Reduction JSInliner::ReduceJSCall(Node* node) {
}
}
// Calls surrounded by a local try-block are only inlined if the
// appropriate flag is active. We also discover the {IfException}
// projection this way.
Node* exception_target = nullptr;
if (NodeProperties::IsExceptionalCall(node, &exception_target) &&
!FLAG_inline_into_try) {
TRACE("Try block surrounds #"
<< exception_target->id() << ":" << exception_target->op()->mnemonic()
<< " and --no-inline-into-try active, so not inlining "
<< *shared_info << " into " << info_->shared_info());
return NoChange();
}
NodeProperties::IsExceptionalCall(node, &exception_target);
// JSInliningHeuristic has already filtered candidates without a
// BytecodeArray by calling SharedFunctionInfoRef::IsInlineable. For the ones

1
src/flag-definitions.h
View File

@ -540,7 +540,6 @@ DEFINE_VALUE_IMPLICATION(stress_inline, min_inlining_frequency, 0)
DEFINE_VALUE_IMPLICATION(stress_inline, polymorphic_inlining, true)
DEFINE_BOOL(trace_turbo_inlining, false, "trace TurboFan inlining")
DEFINE_BOOL(inline_accessors, true, "inline JavaScript accessors")
DEFINE_BOOL(inline_into_try, true, "inline into try blocks")
DEFINE_BOOL(turbo_inline_array_builtins, true,
"inline array builtins in TurboFan code")
DEFINE_BOOL(use_osr, true, "use on-stack replacement")