AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

PPC: [stubs] Change CallICStub to utilize the ConvertReceiverMode.

Browse Source 
Port d80fd48e5d

Original commit message:
    The CallICStub has call-site specific knowledge about the receiver,
    which we did not utilize; plus the CallICStub does in some case know
    whether it is about to [[Call]] a function or potentially some other
    callable. In the common case we actually know that the target is a
    function and so we can use the CallFunction builtin directly instead
    of redispatching in the Call builtin.

R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=chromium:555127, v8:4413
LOG=n

Review URL: https://codereview.chromium.org/1471823002

Cr-Commit-Position: refs/heads/master@{#32185}
This commit is contained in:
mbrandy 2015-11-23 12:00:49 -08:00 committed by Commit bot
parent 395884deb7
commit ee72c4079c
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/ppc/code-stubs-ppc.cc
View File

@ -2619,7 +2619,7 @@ void CallICStub::Generate(MacroAssembler* masm) {
FixedArray::OffsetOfElementAt(TypeFeedbackVector::kWithTypesIndex);
const int generic_offset =
FixedArray::OffsetOfElementAt(TypeFeedbackVector::kGenericCountIndex);
Label extra_checks_or_miss, call;
Label extra_checks_or_miss, call, call_function;
int argc = arg_count();
ParameterCount actual(argc);
@ -2656,9 +2656,10 @@ void CallICStub::Generate(MacroAssembler* masm) {
__ AddSmiLiteral(r6, r6, Smi::FromInt(CallICNexus::kCallCountIncrement), r0);
__ StoreP(r6, FieldMemOperand(r9, count_offset), r0);
__ bind(&call);
__ bind(&call_function);
__ mov(r3, Operand(argc));
__ Jump(masm->isolate()->builtins()->Call(), RelocInfo::CODE_TARGET);
__ Jump(masm->isolate()->builtins()->CallFunction(convert_mode()),
RelocInfo::CODE_TARGET);
__ bind(&extra_checks_or_miss);
Label uninitialized, miss, not_allocation_site;
@ -2699,7 +2700,11 @@ void CallICStub::Generate(MacroAssembler* masm) {
__ LoadP(r7, FieldMemOperand(r5, generic_offset));
__ AddSmiLiteral(r7, r7, Smi::FromInt(1), r0);
__ StoreP(r7, FieldMemOperand(r5, generic_offset), r0);
__ b(&call);
__ bind(&call);
__ mov(r3, Operand(argc));
__ Jump(masm->isolate()->builtins()->Call(convert_mode()),
RelocInfo::CODE_TARGET);
__ bind(&uninitialized);
@ -2745,7 +2750,7 @@ void CallICStub::Generate(MacroAssembler* masm) {
__ Pop(r4);
}
__ b(&call);
__ b(&call_function);
// We are here because tracing is on or we encountered a MISS case we can't
// handle here.