From eef2a462ad9a1ee5a25bec09d9a4a446b124557d Mon Sep 17 00:00:00 2001 From: Andreas Haas Date: Thu, 30 Mar 2017 11:18:23 +0200 Subject: [PATCH] [gn] Remove the wasm_test_signatures source set. The source set only contained a header file, which caused problems when compiling a static library with VS. R=machenbach@chromium.org BUG=v8:6158 Change-Id: I3eed4a888e72cf6a2917190e4a1db7b38006cd0c Reviewed-on: https://chromium-review.googlesource.com/463027 Reviewed-by: Michael Achenbach Commit-Queue: Andreas Haas Cr-Commit-Position: refs/heads/master@{#44263} --- BUILD.gn | 17 +++-------------- test/cctest/BUILD.gn | 2 +- 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 9bdd7d8ae4..6b1ba95297 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -2980,17 +2980,6 @@ v8_source_set("wasm_module_runner") { ] } -v8_source_set("wasm_test_signatures") { - sources = [ - "test/common/wasm/test-signatures.h", - ] - - configs = [ - ":external_config", - ":internal_config_base", - ] -} - v8_source_set("wasm_fuzzer") { sources = [ "test/fuzzer/wasm.cc", @@ -3031,13 +3020,13 @@ v8_fuzzer("wasm_asmjs_fuzzer") { v8_source_set("wasm_code_fuzzer") { sources = [ + "test/common/wasm/test-signatures.h", "test/fuzzer/wasm-code.cc", ] deps = [ ":fuzzer_support", ":wasm_module_runner", - ":wasm_test_signatures", ] configs = [ @@ -3051,13 +3040,13 @@ v8_fuzzer("wasm_code_fuzzer") { v8_source_set("wasm_call_fuzzer") { sources = [ + "test/common/wasm/test-signatures.h", "test/fuzzer/wasm-call.cc", ] deps = [ ":fuzzer_support", ":wasm_module_runner", - ":wasm_test_signatures", ] configs = [ @@ -3223,13 +3212,13 @@ v8_fuzzer("wasm_data_section_fuzzer") { v8_source_set("wasm_compile_fuzzer") { sources = [ + "test/common/wasm/test-signatures.h", "test/fuzzer/wasm-compile.cc", ] deps = [ ":fuzzer_support", ":wasm_module_runner", - ":wasm_test_signatures", ] configs = [ diff --git a/test/cctest/BUILD.gn b/test/cctest/BUILD.gn index 3a30aff345..7c7284d275 100644 --- a/test/cctest/BUILD.gn +++ b/test/cctest/BUILD.gn @@ -11,6 +11,7 @@ v8_executable("cctest") { "$target_gen_dir/resources.cc", ### gcmole(all) ### + "../common/wasm/test-signatures.h", "asmjs/test-asm-typer.cc", "ast-types-fuzz.h", "cctest.cc", @@ -334,7 +335,6 @@ v8_executable("cctest") { "../..:v8_libbase", "../..:v8_libplatform", "../..:wasm_module_runner", - "../..:wasm_test_signatures", "//build/config/sanitizers:deps", "//build/win:default_exe_manifest", ]