AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[lookup] Fix condition of concurrent read ThinStrings

Browse Source 
The CL (crrev.com/c/2905608) make ThinStrings concurrently readable, but
the condition was set incorrectly.

Change-Id: I1cc2c824f75fde7ec6a2343b8650cdfeb475427c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3973071
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Tao Pan <tao.pan@intel.com>
Cr-Commit-Position: refs/heads/main@{#84006}
This commit is contained in:
Pan, Tao 2022-10-24 15:37:28 +08:00 committed by V8 LUCI CQ
parent 88511bb101
commit ef2cc0d66d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects/lookup.cc
View File

@ -1496,8 +1496,8 @@ ConcurrentLookupIterator::Result ConcurrentLookupIterator::TryGetOwnChar(
// TODO(jgruber): Support other string kinds.
Map string_map = string.map(isolate, kAcquireLoad);
InstanceType type = string_map.instance_type();
if (!(InstanceTypeChecker::IsInternalizedString(type)) ||
InstanceTypeChecker::IsThinString(type)) {
if (!(InstanceTypeChecker::IsInternalizedString(type) ||
InstanceTypeChecker::IsThinString(type))) {
return kGaveUp;
}