AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] enable constant folding for 64bit comparisons

Browse Source 
Change-Id: Id545ca00106fb54ee08078177ad7f24842752afe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2332799
Reviewed-by: Georg Neis <neis@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69196}
This commit is contained in:
Tobias Tebbi 2020-07-31 18:41:39 +02:00 committed by Commit Bot
parent a731b86ec9
commit efa3793290
2 changed files with 41 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/compiler/machine-operator-reducer.cc
View File

@ -847,11 +847,34 @@ Reduction MachineOperatorReducer::Reduce(Node* node) {
case IrOpcode::kTrapIf:
case IrOpcode::kTrapUnless:
return ReduceConditional(node);
case IrOpcode::kInt64LessThan:
case IrOpcode::kInt64LessThanOrEqual:
case IrOpcode::kUint64LessThan:
case IrOpcode::kUint64LessThanOrEqual:
case IrOpcode::kInt64LessThan: {
Int64BinopMatcher m(node);
if (m.IsFoldable()) { // K < K => K
return ReplaceBool(m.left().Value() < m.right().Value());
}
return ReduceWord64Comparisons(node);
}
case IrOpcode::kInt64LessThanOrEqual: {
Int64BinopMatcher m(node);
if (m.IsFoldable()) { // K <= K => K
return ReplaceBool(m.left().Value() <= m.right().Value());
}
return ReduceWord64Comparisons(node);
}
case IrOpcode::kUint64LessThan: {
Uint64BinopMatcher m(node);
if (m.IsFoldable()) { // K < K => K
return ReplaceBool(m.left().Value() < m.right().Value());
}
return ReduceWord64Comparisons(node);
}
case IrOpcode::kUint64LessThanOrEqual: {
Uint64BinopMatcher m(node);
if (m.IsFoldable()) { // K <= K => K
return ReplaceBool(m.left().Value() <= m.right().Value());
}
return ReduceWord64Comparisons(node);
}
default:
break;
}

14
test/torque/test-torque.tq
View File

@ -909,6 +909,20 @@ macro TestSliceEnumeration(implicit context: Context)(): Undefined {
@export
macro TestStaticAssert() {
static_assert(1 + 2 == 3);
static_assert(Convert<uintptr>(5) < Convert<uintptr>(6));
static_assert(!(Convert<uintptr>(5) < Convert<uintptr>(5)));
static_assert(!(Convert<uintptr>(6) < Convert<uintptr>(5)));
static_assert(Convert<uintptr>(5) <= Convert<uintptr>(5));
static_assert(Convert<uintptr>(5) <= Convert<uintptr>(6));
static_assert(!(Convert<uintptr>(6) <= Convert<uintptr>(5)));
static_assert(Convert<intptr>(-6) < Convert<intptr>(-5));
static_assert(!(Convert<intptr>(-5) < Convert<intptr>(-5)));
static_assert(!(Convert<intptr>(-5) < Convert<intptr>(-6)));
static_assert(Convert<intptr>(-5) <= Convert<intptr>(-5));
static_assert(Convert<intptr>(-6) <= Convert<intptr>(-5));
static_assert(!(Convert<intptr>(-5) <= Convert<intptr>(-6)));
}
class SmiBox extends HeapObject {