AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of [crankshaft] Also inline Math.ceil. (patchset #1 id:1 of https://codereview.chromium.org/2621903002/ )

Browse Source 
Reason for revert:
Suspected of causing crashes on Canary: https://crbug.com/680108

Original issue's description:
> [crankshaft] Also inline Math.ceil.
>
> Inline calls to Math.ceil(x) as -Math.floor(-x) via the existing fast
> path in Crankshaft.
>
> R=ishell@chromium.org
> BUG=v8:5782
>
> Review-Url: https://codereview.chromium.org/2621903002
> Cr-Commit-Position: refs/heads/master@{#42161}
> Committed: a3859e48c3

TBR=ishell@chromium.org,bmeurer@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=v8:5782, chromium:680108

Review-Url: https://codereview.chromium.org/2629493002
Cr-Commit-Position: refs/heads/master@{#42247}
This commit is contained in:
adamk 2017-01-11 14:37:55 -08:00 committed by Commit bot
parent db883422c8
commit f056905fcc
1 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/crankshaft/hydrogen.cc
View File

@ -8308,23 +8308,6 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinFunctionCall(Call* expr) {
return true;
}
break;
case kMathCeil:
if (expr->arguments()->length() == 1) {
// Math.ceil(x) = -Math.floor(-x)
HValue* minus_zero = Add<HConstant>(-0.0);
HValue* argument = Pop();
Drop(2); // Receiver and function.
argument = AddUncasted<HSub>(minus_zero, argument);
Add<HSimulate>(expr->id(), REMOVABLE_SIMULATE);
{
NoObservableSideEffectsScope scope(this);
argument = AddUncasted<HUnaryMathOperation>(argument, kMathFloor);
argument = AddUncasted<HSub>(minus_zero, argument);
}
ast_context()->ReturnValue(argument);
return true;
}
break;
case kMathImul:
if (expr->arguments()->length() == 2) {
HValue* right = Pop();
@ -8525,23 +8508,6 @@ bool HOptimizedGraphBuilder::TryInlineBuiltinMethodCall(
return true;
}
break;
case kMathCeil:
if (argument_count == 2) {
// Math.ceil(x) = -Math.floor(-x)
HValue* minus_zero = Add<HConstant>(-0.0);
HValue* argument = Pop();
Drop(2); // Receiver and function.
argument = AddUncasted<HSub>(minus_zero, argument);
Add<HSimulate>(ast_id, REMOVABLE_SIMULATE);
{
NoObservableSideEffectsScope scope(this);
argument = AddUncasted<HUnaryMathOperation>(argument, kMathFloor);
argument = AddUncasted<HSub>(minus_zero, argument);
}
ast_context()->ReturnValue(argument);
return true;
}
break;
case kMathPow:
if (argument_count == 3) {
HValue* right = Pop();