AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[snapshot] Fix gcmole issues in code-serializer.cc

Browse Source 
Handlify raw SharedFunctionInfo in
CreateInterpreterDataForDeserializedCode.

Bug: v8:9992
Change-Id: I58fd2a78723cb3cd4784086c171c58cf2c32aacc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1924362
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65044}
This commit is contained in:
Dan Elphick 2019-11-19 14:57:03 +00:00 committed by Commit Bot
parent 96b3ff0257
commit f067ed8315
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/snapshot/code-serializer.cc
View File

@ -235,9 +235,10 @@ void CreateInterpreterDataForDeserializedCode(Isolate* isolate,
Handle<String> name_handle(name, isolate);
SharedFunctionInfo::ScriptIterator iter(isolate, script);
for (SharedFunctionInfo info = iter.Next(); !info.is_null();
info = iter.Next()) {
if (!info.HasBytecodeArray()) continue;
for (SharedFunctionInfo shared_info = iter.Next(); !shared_info.is_null();
shared_info = iter.Next()) {
if (!shared_info.HasBytecodeArray()) continue;
Handle<SharedFunctionInfo> info = handle(shared_info, isolate);
Handle<Code> code = isolate->factory()->CopyCode(Handle<Code>::cast(
isolate->factory()->interpreter_entry_trampoline_for_profiling()));
@ -245,18 +246,18 @@ void CreateInterpreterDataForDeserializedCode(Isolate* isolate,
Handle<InterpreterData>::cast(isolate->factory()->NewStruct(
INTERPRETER_DATA_TYPE, AllocationType::kOld));
interpreter_data->set_bytecode_array(info.GetBytecodeArray());
interpreter_data->set_bytecode_array(info->GetBytecodeArray());
interpreter_data->set_interpreter_trampoline(*code);
info.set_interpreter_data(*interpreter_data);
info->set_interpreter_data(*interpreter_data);
if (!log_code_creation) continue;
Handle<AbstractCode> abstract_code = Handle<AbstractCode>::cast(code);
int line_num = script.GetLineNumber(info.StartPosition()) + 1;
int column_num = script.GetColumnNumber(info.StartPosition()) + 1;
int line_num = script.GetLineNumber(info->StartPosition()) + 1;
int column_num = script.GetColumnNumber(info->StartPosition()) + 1;
PROFILE(isolate,
CodeCreateEvent(CodeEventListener::INTERPRETED_FUNCTION_TAG,
*abstract_code, info, *name_handle, line_num,
*abstract_code, *info, *name_handle, line_num,
column_num));
}
}