From f18a9ad780a71121c2e2cb98d7a869e5b5b38478 Mon Sep 17 00:00:00 2001 From: machenbach Date: Wed, 12 Oct 2016 10:49:44 -0700 Subject: [PATCH] [gn] Add back two warnings V8 uses with gyp BUG=428099 Review-Url: https://codereview.chromium.org/2404283002 Cr-Commit-Position: refs/heads/master@{#40235} --- BUILD.gn | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 1495f17364..ace692a565 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -371,6 +371,18 @@ config("toolchain") { "-fno-inline", ] } + + if (is_clang) { + cflags += [ + # TODO(hans): Remove once http://crbug.com/428099 is resolved. + "-Winconsistent-missing-override", + ] + + if (v8_current_cpu == "x64" || v8_current_cpu == "arm64" || + v8_current_cpu == "mips64el") { + cflags += [ "-Wshorten-64-to-32" ] + } + } } ###############################################################################