AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "[wasm] Ship far jump tables"

Browse Source 
This reverts commit 35ca0abdc5.

Reason for revert: Speculative revert for https://crbug.com/1008597.

Original change's description:
> [wasm] Ship far jump tables
> 
> This flips the --wasm-far-jump-table flag. It will allow for more than
> 128MB of code space per wasm module on arm64, and will increase the
> limit on the number of modules per process on x64 (was ~1000 before,
> because we reserved 1GB for the code space per module).
> 
> R=​mstarzinger@chromium.org
> 
> Bug: v8:9477
> Change-Id: I870ec616f4812e38ef1e3fccf0629854a247bb4f
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815247
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Clemens Backes [né Hammacher] <clemensh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#63967}

TBR=mstarzinger@chromium.org,clemensb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: v8:9477, chromium:1008597
Change-Id: Ie8740e09925130b304a37d97904443026aabae85
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832162
Reviewed-by: Clemens Backes [né Hammacher] <clemensb@chromium.org>
Commit-Queue: Clemens Backes [né Hammacher] <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64050}
This commit is contained in:
Clemens Backes [né Hammacher] 2019-09-30 15:33:12 +00:00 committed by Commit Bot
parent c721203615
commit f1bd1b6b5f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/flags/flag-definitions.h
View File

@ -763,9 +763,10 @@ DEFINE_BOOL(wasm_code_gc, true, "enable garbage collection of wasm code")
DEFINE_BOOL(trace_wasm_code_gc, false, "trace garbage collection of wasm code") DEFINE_BOOL(trace_wasm_code_gc, false, "trace garbage collection of wasm code")
DEFINE_BOOL(stress_wasm_code_gc, false, DEFINE_BOOL(stress_wasm_code_gc, false,
"stress test garbage collection of wasm code") "stress test garbage collection of wasm code")
DEFINE_BOOL(wasm_far_jump_table, true, DEFINE_BOOL(wasm_far_jump_table, false,
"use multiple separate code spaces that might require far jumps " "use multiple separate code spaces that might require far jumps "
"between them") "between them")
DEFINE_IMPLICATION(future, wasm_far_jump_table)
DEFINE_INT(wasm_max_initial_code_space_reservation, 0, DEFINE_INT(wasm_max_initial_code_space_reservation, 0,
"maximum size of the initial wasm code space reservation (in MB)") "maximum size of the initial wasm code space reservation (in MB)")