AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of [profiler] Add extra CHECK to track down crbug.com/665398 (patchset #1 id:1 of https://codereview.chromium.org/2556833003/ )

Browse Source 
Reason for revert:
Not needed anymore. The bug is fixed.

Original issue's description:
> [profiler] Add extra CHECK to track down crbug.com/665398
>
> BUG=chromium:665398
>
> Committed: https://crrev.com/dfc0bb63a1bc115d39f29cfc338aed5676578c4b
> Cr-Commit-Position: refs/heads/master@{#41545}

TBR=yangguo@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:665398

Review-Url: https://codereview.chromium.org/2588973003
Cr-Commit-Position: refs/heads/master@{#41830}
This commit is contained in:
alph 2016-12-19 18:28:39 -08:00 committed by Commit bot
parent 787f1596b6
commit f2281ac7cd
2 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/profiler/profile-generator-inl.h
View File

@ -27,13 +27,7 @@ CodeEntry::CodeEntry(CodeEventListener::LogEventsAndTags tag, const char* name,
deopt_reason_(kNoDeoptReason),
deopt_id_(kNoDeoptimizationId),
line_info_(line_info),
instruction_start_(instruction_start) {
// TODO(alph): Extra check to help catch crbug.com/665398
// Remove before 5.8 branch
#if V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION == 7
CHECK(name);
#endif
}
instruction_start_(instruction_start) {}
ProfileNode::ProfileNode(ProfileTree* tree, CodeEntry* entry,
ProfileNode* parent)

5
src/profiler/profile-generator.cc
View File

@ -424,11 +424,6 @@ namespace {
void BuildNodeValue(const ProfileNode* node, TracedValue* value) {
const CodeEntry* entry = node->entry();
value->BeginDictionary("callFrame");
// TODO(alph): Extra check to help catch crbug.com/665398
// Remove before 5.8 branch
#if V8_MAJOR_VERSION == 5 && V8_MINOR_VERSION == 7
CHECK(entry->name());
#endif
value->SetString("functionName", entry->name());
if (*entry->resource_name()) {
value->SetString("url", entry->resource_name());