AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[grokdump] Mark embedded builtins builds as non-shipping

Browse Source 
Builds with and without embedded builtins (when combined with RO_SPACE
changes) results in different v8heapconst.py. So this marks embedded
builds as non-shipping. When embedded builtins becomes the default then
this non-embedded builds should be marked as non-shipping.

Bug: v8:7464
Change-Id: I8649183daf63ae9f54ed6207ed1104ecf33c89ff
Reviewed-on: https://chromium-review.googlesource.com/1005515
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52540}
This commit is contained in:
Dan Elphick 2018-04-11 09:09:36 +01:00 committed by Commit Bot
parent fc612a7102
commit f23e6e8839
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/mkgrokdump/mkgrokdump.cc
View File

@ -27,7 +27,11 @@ static const char* kHeader =
// Non-snapshot builds allocate objects to different places.
// Debug builds emit debug code, affecting code object sizes.
#if defined(V8_USE_SNAPSHOT) && !defined(DEBUG)
// Embedded builtins cause objects to be allocated in different locations.
// TODO(jgruber,v8:6666): Change the V8_EMBEDDED_BUILTINS condition when it
// becomes the default.
#if !defined(V8_EMBEDDED_BUILTINS) && defined(V8_USE_SNAPSHOT) && \
!defined(DEBUG)
static const char* kBuild = "shipping";
#else
static const char* kBuild = "non-shipping";