cppgc: Reenable pointer compression on M1
Since the overall motionmark regression is minor (<0.5%), we decided to get benefits of pointer compression on M1. The CL can also slightly regress speedometer2 (~0.3%). Bug: chromium:1325007 Change-Id: Ib278f0e82e0ebde563caac79b9f32edfe2d09a53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3840301 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#82586}
This commit is contained in:
parent
b3a27f22cd
commit
f2f38dee51
5
BUILD.gn
5
BUILD.gn
@ -850,15 +850,10 @@ if (cppgc_enable_caged_heap) {
|
||||
# Always enable young generation compile time flag if caged heap is enabled.
|
||||
cppgc_enable_young_generation = true
|
||||
|
||||
if (is_linux || (is_mac && v8_current_cpu != "arm64") || is_win ||
|
||||
is_chromeos || is_android || is_fuchsia) {
|
||||
# Enable on all platforms but M1 and Fuchsia.
|
||||
# Pointer compression regresses binary size on Fuchsia by about 300K.
|
||||
# However, the change improves Oilpan memory by 15-20% (2-4% of PMF),
|
||||
# which is beneficial for memory-impoverished platforms.
|
||||
# TODO(1325007): Fix MotionMark regressions on M1.
|
||||
cppgc_enable_pointer_compression = true
|
||||
}
|
||||
}
|
||||
if (cppgc_enable_young_generation) {
|
||||
enabled_external_cppgc_defines += [ "CPPGC_YOUNG_GENERATION" ]
|
||||
|
Loading…
Reference in New Issue
Block a user