AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Remove unneeded DeferredHandleScope

Browse Source 
R=ahaas@chromium.org

Bug: v8:7733
Change-Id: Ib3133e882c0a798f76478492a6663356267a1578
Reviewed-on: https://chromium-review.googlesource.com/1049546
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53049}
This commit is contained in:
Clemens Hammacher 2018-05-08 08:59:10 +02:00 committed by Commit Bot
parent 3fe7d698b8
commit f33575be45
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/handles.cc
View File

@ -176,7 +176,8 @@ DeferredHandleScope::DeferredHandleScope(Isolate* isolate)
HandleScopeData* data = impl_->isolate()->handle_scope_data();
Object** new_next = impl_->GetSpareOrNewBlock();
Object** new_limit = &new_next[kHandleBlockSize];
// Check that at least one HandleScope exists, see the class description.
// Check that at least one HandleScope with at least one Handle in it exists,
// see the class description.
DCHECK(!impl_->blocks()->empty());
// Check that we are not in a SealedHandleScope.
DCHECK(data->limit == &impl_->blocks()->back()[kHandleBlockSize]);

9
src/wasm/module-compiler.cc
View File

@ -3067,14 +3067,7 @@ class AsyncCompileJob::PrepareAndStartCompile : public CompileStep {
Isolate* isolate = job_->isolate_;
Handle<Code> centry_stub = CodeFactory::CEntry(isolate);
{
// Now reopen the handles in a deferred scope in order to use
// them in the concurrent steps.
DeferredHandleScope deferred(isolate);
job_->centry_stub_ = Handle<Code>(*centry_stub, isolate);
job_->deferred_handles_.push_back(deferred.Detach());
}
job_->centry_stub_ = CodeFactory::CEntry(isolate);
DCHECK_LE(module_->num_imported_functions, module_->functions.size());
// Create the compiled module object and populate with compiled functions