AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

PPC: Support fast-path allocation for subclass constructors with correctly initialized initial maps.

Browse Source 
Port b9d25d86a8

R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=v8:3330
LOG=n

Review URL: https://codereview.chromium.org/1434793002

Cr-Commit-Position: refs/heads/master@{#31926}
This commit is contained in:
mbrandy 2015-11-10 11:55:37 -08:00 committed by Commit bot
parent 432d1a6f6a
commit f372694458
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/ppc/builtins-ppc.cc
View File

@ -396,18 +396,24 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ cmpi(r5, Operand::Zero());
__ bne(&rt_call);
// Fall back to runtime if the original constructor and function differ.
__ cmp(r4, r6);
// Verify that the original constructor is a JSFunction.
__ CompareObjectType(r6, r8, r7, JS_FUNCTION_TYPE);
__ bne(&rt_call);
// Load the initial map and verify that it is in fact a map.
// r4: constructor function
// r6: original constructor
__ LoadP(r5,
FieldMemOperand(r4, JSFunction::kPrototypeOrInitialMapOffset));
FieldMemOperand(r6, JSFunction::kPrototypeOrInitialMapOffset));
__ JumpIfSmi(r5, &rt_call);
__ CompareObjectType(r5, r8, r7, MAP_TYPE);
__ bne(&rt_call);
// Fall back to runtime if the expected base constructor and base
// constructor differ.
__ LoadP(r8, FieldMemOperand(r5, Map::kConstructorOrBackPointerOffset));
__ cmp(r4, r8);
__ bne(&rt_call);
// Check that the constructor is not constructing a JSFunction (see
// comments in Runtime_NewObject in runtime.cc). In which case the
// initial map's instance type would be JS_FUNCTION_TYPE.
@ -430,9 +436,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ cmpi(r11, Operand(Map::kSlackTrackingCounterEnd));
__ bne(&allocate);
__ push(r4);
__ Push(r5, r4); // r4 = constructor
__ Push(r4, r5, r5); // r5 = initial map
__ CallRuntime(Runtime::kFinalizeInstanceSize, 1);
__ Pop(r4, r5);