AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix UBSan breakage due to pointer/ref issue

Browse Source 
Bug: v8:9241
Change-Id: I0e2b73e3f98b1863e790a7d28a716fe9e3478103
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1610437
Reviewed-by: Igor Sheludko <ishell@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61455}
This commit is contained in:
Frank Tang 2019-05-13 10:05:52 -07:00 committed by Commit Bot
parent c7b9fd2599
commit f37398bc0b
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects/js-number-format.cc
View File

@ -728,7 +728,9 @@ Maybe<icu::UnicodeString> IcuFormatNumber(
double number = numeric_obj->Number();
formatted = number_format.formatDouble(number, status);
}
formatted.getAllFieldPositions(*fp_iter, status);
if (fp_iter) {
formatted.getAllFieldPositions(*fp_iter, status);
}
icu::UnicodeString result = formatted.toString(status);
if (U_FAILURE(status)) {
THROW_NEW_ERROR_RETURN_VALUE(isolate,