[logging] Replace last uses of FLAG_trace_ic with FLAG_log_ic

Long live --log-ic!

Change-Id: I4d8cefd64cdbf693a868019deb2a864d43cbd2ff
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964393
Auto-Submit: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Camillo Bruni <cbruni@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75159}

src/flags/flag-definitions.h

@@ -1530,12 +1530,10 @@ DEFINE_BOOL(use_idle_notification, true,
 // ic.cc
 DEFINE_BOOL(log_ic, false,
             "Log inline cache state transitions for tools/ic-processor")
-DEFINE_BOOL(trace_ic, false, "See --log-ic")
-DEFINE_IMPLICATION(trace_ic, log_ic)
 DEFINE_IMPLICATION(log_ic, log_code)
 DEFINE_GENERIC_IMPLICATION(
-    trace_ic, TracingFlags::ic_stats.store(
+    log_ic, TracingFlags::ic_stats.store(
-                  v8::tracing::TracingCategoryObserver::ENABLED_BY_NATIVE))
+                v8::tracing::TracingCategoryObserver::ENABLED_BY_NATIVE))
 DEFINE_BOOL_READONLY(fast_map_update, false,
                      "enable fast map update by caching the migration target")
 DEFINE_INT(max_valid_polymorphic_map_count, 4,

src/objects/shared-function-info.tq

@@ -75,7 +75,7 @@ class SharedFunctionInfo extends HeapObject {
   // SharedFunctionInfo represents within its script, or -1 if this
   // SharedFunctionInfo object doesn't correspond to a parsed FunctionLiteral.
   function_literal_id: int32;
-  // [unique_id] - For --trace-maps purposes, an identifier that's persistent
+  // [unique_id] - For --log-maps purposes, an identifier that's persistent
   // even if the GC moves this SharedFunctionInfo.
   @if(V8_SFI_HAS_UNIQUE_ID) unique_id: int32;
 }

test/cctest/test-log.cc

@@ -880,7 +880,7 @@ void ValidateMapDetailsLogging(v8::Isolate* isolate,
       i::Map::cast(obj).Print();
       FATAL(
           "Map (%p, #%zu) creation not logged during startup with "
-          "--trace-maps!"
+          "--log-maps!"
           "\n# Expected Log Line: map-create, ... %p",
           reinterpret_cast<void*>(obj.ptr()), i,
           reinterpret_cast<void*>(obj.ptr()));
@@ -890,7 +890,7 @@ void ValidateMapDetailsLogging(v8::Isolate* isolate,
       i::Map::cast(obj).Print();
       FATAL(
           "Map (%p, #%zu) details not logged during startup with "
-          "--trace-maps!"
+          "--log-maps!"
           "\n# Expected Log Line: map-details, ... %p",
           reinterpret_cast<void*>(obj.ptr()), i,
           reinterpret_cast<void*>(obj.ptr()));

test/mjsunit/tools/log-ic.js

@@ -2,11 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --trace-ic --logfile=test/mjsunit/tools/trace-ic-test.log
+// Flags: --log-ic --logfile=test/mjsunit/tools/log-ic-test.log
 // Flags: --allow-natives-syntax
 
 // The idea behind this test is to make sure we do not crash when using the
-// --trace-ic flag.
+// --log-ic flag.
 
 
 (function testLoadIC() {

test/mjsunit/tools/processor.mjs

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --logfile='+' --log --trace-maps --trace-ic --log-code
+// Flags: --logfile='+' --log --log-maps --log-ic --log-code
 // Flags: --log-function-events --no-stress-opt
 
 import { Processor } from "../../../tools/system-analyzer/processor.mjs";

tools/system-analyzer/index.html

@@ -134,7 +134,7 @@ found in the LICENSE file. -->
               Log <a href="https://v8.dev/blog/fast-properties">Maps</a>
           </dd>
           <dt>
-            <a href="https://source.chromium.org/search?q=FLAG_trace_ic">
+            <a href="https://source.chromium.org/search?q=FLAG_log_ic">
               <code>--log-ic</code>
             </a>
           </dt>
@@ -165,6 +165,12 @@ found in the LICENSE file. -->
             </a>
           </dt>
           <dd>Log various API uses.</dd>
+          <dt>
+            <a href="https://source.chromium.org/search?q=FLAG_prof">
+              <code>--prof</code>
+            </a>
+          </dt>
+          <dd>Log ticks from the sampling profiler.</dd>
         </dl>
 
         <h3>Keyboard Shortcuts for Navigation</h3>