Quick fix for array reduction tests
These tests are likely missing %PrepareFunctionForOptimization annotation of lambdas. Thus lambdas are no longer inlined and %DeoptimizeNow does nothing, while the entire point of these tests is to test deoptimization paths. Disabling lazy feedback allocation is a quick fix to restore coverage until we can land a more complete fix (for details see the linked bug). Bug: v8:10195 Change-Id: I4038cdc5718230253ffb5bbc57d574342c652377 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2054096 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#66261}
This commit is contained in:
parent
b325f7ec45
commit
f44027169d
@ -25,11 +25,11 @@
|
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
|
||||
// Flags: --allow-natives-syntax
|
||||
// Flags: --allow-natives-syntax --opt --no-lazy-feedback-allocation
|
||||
|
||||
/**
|
||||
* @fileoverview Test reduce and reduceRight
|
||||
*/
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
function clone(v) {
|
||||
// Shallow-copies arrays, returns everything else verbatim.
|
||||
|
@ -2,11 +2,11 @@
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --opt --no-always-opt
|
||||
// Flags: --allow-natives-syntax --opt --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
/**
|
||||
* @fileoverview Test reduce and reduceRight
|
||||
*/
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
function clone(v) {
|
||||
// Shallow-copies arrays, returns everything else verbatim.
|
||||
|
@ -2,11 +2,11 @@
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --opt --no-always-opt
|
||||
// Flags: --allow-natives-syntax --opt --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
/**
|
||||
* @fileoverview Test reduce and reduceRight
|
||||
*/
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
function clone(v) {
|
||||
// Shallow-copies arrays, returns everything else verbatim.
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --turbo-inline-array-builtins --opt
|
||||
// Flags: --no-always-opt
|
||||
// Flags: --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
// Early exit from every functions properly.
|
||||
(() => {
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --turbo-inline-array-builtins --opt
|
||||
// Flags: --no-always-opt
|
||||
// Flags: --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
// Unknown field access leads to soft-deopt unrelated to find, should still
|
||||
// lead to correct result.
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --turbo-inline-array-builtins --opt
|
||||
// Flags: --no-always-opt
|
||||
// Flags: --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
// Unknown field access leads to soft-deopt unrelated to findIndex, should still
|
||||
// lead to correct result.
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --turbo-inline-array-builtins --opt
|
||||
// Flags: --no-always-opt
|
||||
// Flags: --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
// Early exit from some functions properly.
|
||||
(() => {
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --expose-gc --turbo-inline-array-builtins
|
||||
// Flags: --opt --no-always-opt
|
||||
// Flags: --opt --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
// Unknown field access leads to soft-deopt unrelated to filter, should still
|
||||
// lead to correct result.
|
||||
|
@ -3,6 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --expose-gc --turbo-inline-array-builtins
|
||||
// Flags: --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
var a = [
|
||||
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
|
||||
|
@ -3,7 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --expose-gc --turbo-inline-array-builtins
|
||||
// Flags: --opt --no-always-opt
|
||||
// Flags: --opt --no-always-opt --no-lazy-feedback-allocation
|
||||
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
var a = [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,0,0];
|
||||
var b = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25];
|
||||
|
@ -3,10 +3,11 @@
|
||||
// found in the LICENSE file.
|
||||
|
||||
// Flags: --allow-natives-syntax --opt --no-always-opt
|
||||
// Flags: --no-lazy-feedback-allocation
|
||||
|
||||
/**
|
||||
* @fileoverview Test reduce and reduceRight
|
||||
*/
|
||||
// TODO(v8:10195): Fix these tests s.t. we assert deoptimization occurs when
|
||||
// expected (e.g. in a %DeoptimizeNow call), then remove
|
||||
// --no-lazy-feedback-allocation.
|
||||
|
||||
function clone(v) {
|
||||
// Shallow-copies arrays, returns everything else verbatim.
|
||||
|
Loading…
Reference in New Issue
Block a user