AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[bigint,compiler] Fix endianness issue in bitfield access.

Browse Source 
See https://chromium-review.googlesource.com/c/v8/v8/+/904725.

Change-Id: I6b017c0a8d1c521a83e0c6b5315e1c9689bb4f19
Bug: v8:6791
Reviewed-on: https://chromium-review.googlesource.com/906422
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51140}
This commit is contained in:
Georg Neis 2018-02-07 10:55:40 +01:00 committed by Commit Bot
parent a2aac98ddf
commit f4e42f9d31
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/access-builder.cc
View File

@ -56,7 +56,7 @@ FieldAccess AccessBuilder::ForHeapNumberValue() {
FieldAccess AccessBuilder::ForBigIntBitfield() { FieldAccess AccessBuilder::ForBigIntBitfield() {
FieldAccess access = { FieldAccess access = {
kTaggedBase, BigInt::kBitfieldOffset, MaybeHandle<Name>(), kTaggedBase, BigInt::kBitfieldOffset, MaybeHandle<Name>(),
MaybeHandle<Map>(), TypeCache::Get().kInt32, MachineType::Int32(), MaybeHandle<Map>(), TypeCache::Get().kInt32, MachineType::IntPtr(),
kNoWriteBarrier}; kNoWriteBarrier};
return access; return access;
} }

6
src/compiler/effect-control-linearizer.cc
View File

@ -1175,9 +1175,9 @@ void EffectControlLinearizer::TruncateTaggedPointerToBit(
__ Bind(&if_bigint); __ Bind(&if_bigint);
{ {
Node* bitfield = __ LoadField(AccessBuilder::ForBigIntBitfield(), value); Node* bitfield = __ LoadField(AccessBuilder::ForBigIntBitfield(), value);
Node* length_is_zero = __ Word32Equal( Node* length_is_zero = __ WordEqual(
__ Word32And(bitfield, __ Int32Constant(BigInt::LengthBits::kMask)), __ WordAnd(bitfield, __ IntPtrConstant(BigInt::LengthBits::kMask)),
zero); __ IntPtrConstant(0));
__ Goto(done, __ Word32Equal(length_is_zero, zero)); __ Goto(done, __ Word32Equal(length_is_zero, zero));
} }
} }