AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build] Simplify snapshot target

Browse Source 
Drops unnecessary visibility exception and uses minimum deps required
for snapshot target.

Change-Id: I4098a443e9df31c25551540a0b6edfe9500f7bcd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910943
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64907}
This commit is contained in:
Michael Achenbach 2019-11-12 12:17:08 +01:00 committed by Commit Bot
parent 75a6132505
commit f616b37235
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
BUILD.gn
View File

@ -1387,7 +1387,7 @@ action("v8_dump_build_config") {
v8_source_set("v8_snapshot") {
visibility = [ ":*" ] # Targets in this file can depend on this.
deps = []
deps = [ ":v8_maybe_icu" ]
public_deps = [
# This should be public so downstream targets can declare the snapshot
# output file as their inputs.
@ -1408,8 +1408,6 @@ v8_source_set("v8_snapshot") {
configs = [ ":internal_config" ]
if (v8_use_external_startup_data) {
deps += [ ":v8_base" ]
sources += [ "src/snapshot/snapshot-external.cc" ]
if (v8_use_multi_snapshots) {
@ -1422,11 +1420,6 @@ v8_source_set("v8_snapshot") {
}
}
} else {
# Also top-level visibility targets can depend on this.
visibility += [ "//:gn_visibility" ]
public_deps += [ ":v8_maybe_icu" ]
sources += [ "$target_gen_dir/snapshot.cc" ]
}
}