Compute the same hash for all NaN values.
Both SameValue and SameValueZero consider different NaNs equal, so we better assign the same hash value to all NaNs. BUG=v8:3859 LOG=y R=verwaest@chromium.org Review URL: https://codereview.chromium.org/897593002 Cr-Commit-Position: refs/heads/master@{#26391}
This commit is contained in:
parent
9cce4ff285
commit
f6e02e195c
@ -717,7 +717,9 @@ Object* Object::GetHash() {
|
||||
// The object is either a number, a name, an odd-ball,
|
||||
// a real JS object, or a Harmony proxy.
|
||||
if (IsNumber()) {
|
||||
uint32_t hash = ComputeLongHash(double_to_uint64(Number()));
|
||||
uint32_t hash = std::isnan(Number())
|
||||
? Smi::kMaxValue
|
||||
: ComputeLongHash(double_to_uint64(Number()));
|
||||
return Smi::FromInt(hash & Smi::kMaxValue);
|
||||
}
|
||||
if (IsName()) {
|
||||
|
6
test/mjsunit/regress/regress-3859.js
Normal file
6
test/mjsunit/regress/regress-3859.js
Normal file
@ -0,0 +1,6 @@
|
||||
// Copyright 2015 the V8 project authors. All rights reserved.
|
||||
// Use of this source code is governed by a BSD-style license that can be
|
||||
// found in the LICENSE file.
|
||||
|
||||
assertEquals(1, new Set([NaN, NaN, NaN]).size);
|
||||
assertEquals(42, new Map([[NaN, 42]]).get(NaN));
|
Loading…
Reference in New Issue
Block a user